API page: https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Field%21F...

The source looks like this:

> * text field or the @code target_id @endcode of an entity reference. If the

but the output lines are getting split, which looks wrong.

I'm not sure @code is meant to be used inline.

CommentFileSizeAuthor
#9 2926479-9-D8.patch872 bytesmohit1604
#5 2926479-5.patch742 bytesbhanuprakashnani

Comments

joachim created an issue. See original summary.

bhanuprakashnani’s picture

bhanuprakashnani commented
Assigned: Unassigned » bhanuprakashnani
bhanuprakashnani’s picture

bhanuprakashnani commented
bhanuprakashnani’s picture

bhanuprakashnani commented

@joachim,

Working on this for now.

bhanuprakashnani’s picture

bhanuprakashnani commented
Status: Active » Needs review
StatusFileSize
new 2926479-5.patch742 bytes

@joachim Attached the patch please review.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

bhanuprakashnani’s picture

bhanuprakashnani commented

Can i get a review please?

joachim’s picture

joachim commented
Status: Needs review » Needs work

The change is OK, but the line is now shorter, so it should be re-flowed.

mohit1604’s picture

mohit1604 commented
Assigned: bhanuprakashnani » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 2926479-9-D8.patch872 bytes

This should be fine.

joachim’s picture

joachim commented
Status: Needs review » Reviewed & tested by the community

Yup, looks good to me!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

Adding credit to @joachim for creating and reviewing this issue.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed d541a7f8b4 to 8.6.x and 183d71fc76 to 8.5.x. Thanks!

  • alexpott committed d541a7f on 8.6.x 
    Issue #2926479 by bhanuprakashnani, mohit1604, joachim: incorrectly...

  • alexpott committed 183d71f on 8.5.x 
    Issue #2926479 by bhanuprakashnani, mohit1604, joachim: incorrectly...
bhanuprakashnani’s picture

bhanuprakashnani commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.