Migrate UI - review help text

Postponed on a trifecta.

No longer blocked.

Yes, it should show those.

Some minor feedback.

1. +++ b/core/modules/migrate_drupal_ui/migrate_drupal_ui.module
   @@ -25,9 +25,11 @@ function migrate_drupal_ui_help($route_name, RouteMatchInterface $route_match) {
   +      $output .= '<dd><ol><li>' . t('If an upgrade has been performed on this site you will informed.') . '</li>';
   

   Missing a word. Maybe its 'be'?

2. +++ b/core/modules/migrate_drupal_ui/migrate_drupal_ui.module
   @@ -25,9 +25,11 @@ function migrate_drupal_ui_help($route_name, RouteMatchInterface $route_match) {
   +      $output .= '<li>' . t('You need to enter the database credentials of the Drupal site that you want to upgrade. You can also include its files directory in the upgrade.') . '</li>';
   

   It would be good to show examples or make it clear about local files (full path to them) vs remote files (fqdn + path to files).

Need to make the changes according to @heddn comment. So moving to needs work

Tried addressing the last comment by @heddn.

+++ b/core/modules/migrate_drupal_ui/migrate_drupal_ui.module
@@ -25,9 +25,11 @@ function migrate_drupal_ui_help($route_name, RouteMatchInterface $route_match) {
+      $output .= '<li>' . t('You need to enter the database credentials of the Drupal site that you want to upgrade. You can also include its files directory in the upgrade. For example local files (/var/www/docroot) or remote files (fqdn + path to files).') . '</li>';

I think something like:

Examples of local files and remote files, respectively: /var/www/html or http://www.example.com.

And can we confirm we don't need to include sites/default/files, etc in these or if we do need it. I don't recall off the top of my head.

I think finally makes more sense here, it's the end of a dump of information, not a sequence.

This looks like a good improvement - will be superceded eventually by the new help system, but that's fine can still make an incremental improvement that might or might not get carried over. Since it's new translations, 9.2.x-only at this point.

Committed 1272ee6 and pushed to 9.2.x. Thanks!