Problem/Motivation

Follow-up to #2940367: Update Symfony components to 3.4.4

Proposed resolution

Update Symfony components to 3.4.9
Update Twig to v1.35.3

Remaining tasks

Review
Commit

User interface changes

N/A

API changes

N/A

Data model changes

N/A

CommentFileSizeAuthor
#19 2951269-19.patch31.11 KBslasher13
#8 interdiff.txt18.66 KBslasher13
#8 2951269-8.patch27.65 KBslasher13
#7 2951269-7.patch26.94 KBslasher13
#7 interdiff.txt20.6 KBslasher13
#2 2951269-2.patch24.11 KBjibran

Comments

jibran created an issue. See original summary.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Active » Needs review
StatusFileSize
new 2951269-2.patch24.11 KB 
  - Updating symfony/class-loader (v3.4.4 => v3.4.6): Loading from cache
> Drupal\Core\Composer\Composer::vendorTestCodeCleanup
  - Updating symfony/debug (v3.4.4 => v3.4.6): Loading from cache
> Drupal\Core\Composer\Composer::vendorTestCodeCleanup
  - Updating symfony/polyfill-mbstring (v1.6.0 => v1.7.0): Loading from cache
> Drupal\Core\Composer\Composer::vendorTestCodeCleanup
  - Updating symfony/console (v3.4.4 => v3.4.6): Loading from cache
> Drupal\Core\Composer\Composer::vendorTestCodeCleanup
  - Updating symfony/dependency-injection (v3.4.4 => v3.4.6): Loading from cache
> Drupal\Core\Composer\Composer::vendorTestCodeCleanup
  - Updating symfony/polyfill-php70 (v1.6.0 => v1.7.0): Loading from cache
> Drupal\Core\Composer\Composer::vendorTestCodeCleanup
  - Updating symfony/http-foundation (v3.4.4 => v3.4.6): Loading from cache
> Drupal\Core\Composer\Composer::vendorTestCodeCleanup
  - Updating symfony/event-dispatcher (v3.4.4 => v3.4.6): Loading from cache
> Drupal\Core\Composer\Composer::vendorTestCodeCleanup
  - Updating symfony/http-kernel (v3.4.4 => v3.4.6): Loading from cache
> Drupal\Core\Composer\Composer::vendorTestCodeCleanup
  - Updating symfony/routing (v3.4.4 => v3.4.6): Loading from cache
> Drupal\Core\Composer\Composer::vendorTestCodeCleanup
  - Updating symfony/serializer (v3.4.4 => v3.4.6): Loading from cache
> Drupal\Core\Composer\Composer::vendorTestCodeCleanup
  - Updating symfony/translation (v3.4.4 => v3.4.6): Loading from cache
> Drupal\Core\Composer\Composer::vendorTestCodeCleanup
  - Updating symfony/validator (v3.4.4 => v3.4.6): Loading from cache
> Drupal\Core\Composer\Composer::vendorTestCodeCleanup
  - Updating symfony/process (v3.4.4 => v3.4.6): Loading from cache
> Drupal\Core\Composer\Composer::vendorTestCodeCleanup
  - Updating symfony/polyfill-iconv (v1.6.0 => v1.7.0): Loading from cache
> Drupal\Core\Composer\Composer::vendorTestCodeCleanup
  - Updating symfony/yaml (v3.4.4 => v3.4.6): Loading from cache
> Drupal\Core\Composer\Composer::vendorTestCodeCleanup
  - Updating twig/twig (v1.35.0 => v1.35.2): Loading from cache
> Drupal\Core\Composer\Composer::vendorTestCodeCleanup
  - Updating symfony/css-selector (v3.4.4 => v3.4.6): Loading from cache
> Drupal\Core\Composer\Composer::vendorTestCodeCleanup
  - Updating symfony/phpunit-bridge (v3.4.4 => v3.4.6): Loading from cache
> Drupal\Core\Composer\Composer::vendorTestCodeCleanup
  - Updating symfony/dom-crawler (v3.4.4 => v3.4.6): Loading from cache
> Drupal\Core\Composer\Composer::vendorTestCodeCleanup
  - Updating symfony/browser-kit (v3.4.4 => v3.4.6): Loading from cache
> Drupal\Core\Composer\Composer::vendorTestCodeCleanup
andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Reviewed & tested by the community

Let's get this in

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

@jibran you should check for duplicates before filing issues #2949225: Update Symfony components to 3.4.5 exists. But as we've got yet another Symfony release lets close that one in favour of this one.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented

I did check for duplicates, kind of :). The duplicate is not linked to any earlier issues or meta so it was hard to find. Also, I didn't search the issue queue I just glanced the first two pages and didn't find anything there.

bojanz’s picture

bojanz commented
Status: Reviewed & tested by the community » Needs review

I have found that symfony/phpunit-bridge 3.4.5 and 3.4.6 no longer show deprecation warnings, just their counts, due to: https://github.com/symfony/symfony/issues/26476

Can someone confirm this locally?

The solution would be to hardcode the symfony/phpunit-bridge requirement to 3.4.4 until the regression is resolved.

slasher13’s picture

slasher13
Primary language German
commented
Issue summary: View changes
StatusFileSize
new interdiff.txt20.6 KB
new 2951269-7.patch26.94 KB

Update Symfony components to 3.4.8
Fixes: https://github.com/symfony/symfony/issues/26476
Fix: https://github.com/symfony/symfony/pull/26794

slasher13’s picture

slasher13
Primary language German
commented
Issue summary: View changes
StatusFileSize
new 2951269-8.patch27.65 KB
new interdiff.txt18.66 KB

Update Symfony components to 3.4.9 and symfony polyfills to 1.8

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

Before we do this can we get #2912169: Inject the argument resolver into HttpKernel::__construct and #2961691: Change SYMFONY_DEPRECATIONS_HELPER back to strict done so we can be sure we're not storing up new technical debt?

Status: Needs review » Needs work

The last submitted patch, 8: 2951269-8.patch, failed testing. View results

slasher13’s picture

slasher13
Primary language German
commented
Status: Needs work » Needs review

Tested after #2912169 and #2961691 were in.

Random error i guess.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

The random fail was #2972531: Random fail in TipPluginTextTest

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs review » Reviewed & tested by the community

Looks good to go. I've checked and the latest versions are still the latest.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

adding @alexpott to review credits

  • larowlan committed a085bc6 on 8.6.x 
    Issue #2951269 by slasher13, jibran, alexpott: Update symfony/* and twig...
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Reviewed & tested by the community » Fixed

Committed as a085bc6 and pushed to 8.6.x

slasher13’s picture

slasher13
Primary language German
commented

Why not commit it to 8.5.x?

slasher13’s picture

slasher13
Primary language German
commented
Version: 8.6.x-dev » 8.5.x-dev
Status: Fixed » Needs review

Tested 8.5.x:
https://www.drupal.org/project/drupal/issues/2951269#comment-12595056

slasher13’s picture

slasher13
Primary language German
commented
StatusFileSize
new 2951269-19.patch31.11 KB

Update to symfony 3.4.11 (security release)
https://symfony.com/blog/symfony-3-4-11-released

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

@slasher13 can we file a new issue to update to 3.4.11 - we need to do 8.6.x first. Thanks and yes we'll backport to 8.5.x

slasher13’s picture

slasher13
Primary language German
commented
Related issues: +#2976417: Update symfony (security release)

created new issue #2976417: Update symfony (security release) for 8.6.x

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs review » Reviewed & tested by the community

#19 is RTBC.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 85c790c and pushed to 8.5.x. Thanks!

I've backported #8 to 8.5.x - we'll do 8.5.x and 8.6.x updates to 3.4.11 in #2976417: Update symfony (security release)

  • alexpott committed 85c790c on 8.5.x authored by larowlan 
    Issue #2951269 by slasher13, jibran, alexpott: Update symfony/* and twig...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.