Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Problem/Motivation
./core/phpunit.xml.dist currently has the following documentation:
<!-- To disable deprecation testing uncomment the next line. -->
<env name="SYMFONY_DEPRECATIONS_HELPER" value="weak_vendors"/>
The comment was added in #2870194: Ensure that process-isolated tests can use Symfony's PHPunit bridge to catch usages of deprecated code when the lines said:
<!-- To disable deprecation testing uncomment the next line. -->
<!-- <env name="SYMFONY_DEPRECATIONS_HELPER" value="disabled"/> -->
Since the the line was uncommented in #2927806: Use PHPUnit 6 for testing when PHP version >= 7.2 to its current state.
Proposed resolution
Update the comment to correctly instruct how to disable deprecation testing.
Remaining tasks
- Write a patch
- Review
- Commit
User interface changes
None.
API changes
None.
Data model changes
None.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | 2962736-3.patch | 885 bytes | idebr |
Comments
Comment #2
idebr commentedComment #3
idebr commentedSuggestion for updated comment:
Comment #4
mile23Nice catch.
Comment #5
alexpottThis was probably my fault...
Committed and pushed 6de60bc459 to 8.6.x and eb2e735c35 to 8.5.x. Thanks!
Eventually we want to swap this back - see #2961691: Change SYMFONY_DEPRECATIONS_HELPER back to strict