Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.I thought that there was an automatic spell checker; I'm not sure how this was missed and whether I should be filing this under a different META issue.
In hook_queue_info_alter docblock. There is a typo processesed. Also there is a incorrect @see \Drupal\Core\QueueWorker\QueueWorkerInterface which should be \Drupal\Core\Queue\QueueWorkerInterface
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | fix_typos_in_core.api_.php-2962961-9.patch | 2.2 KB | vegantriathlete |
| #9 | interdiff-8-9.txt | 1.05 KB | vegantriathlete |
| #5 | fix_typos_in_core.api_.php-2962961-5.patch | 1.28 KB | vegantriathlete |
| #5 | interdiff-2-5.txt | 665 bytes | vegantriathlete |
| #2 | misspelled_word-2962961-2.patch | 771 bytes | vegantriathlete |
Comments
Comment #2
vegantriathletepatch attached!
Comment #3
msankhala commented@vegantriathlete Patch looks good. I had a quick look at core.api.php. There are few more things which can be fixed. I think that can be part of this patch.
In
hook_queue_info_alterdocblock. There is a typoprocessesed.Also there is a incorrect@see \Drupal\Core\QueueWorker\QueueWorkerInterfacewhich should be\Drupal\Core\Queue\QueueWorkerInterfaceComment #4
msankhala commentedComment #5
vegantriathlete@msankhala: Thanks for the suggestions!
Comment #6
msankhala commentedGood work @vegantriathlete. This patch applies cleanly.
Comment #7
msankhala commentedComment #8
alexpottThere are 2 other things to fix if we are fixing up this file.
There's also
\Drupal\Core\Cache\CacheableDepenencyInterface::getCacheTags(),timespanshould also betime span- whilst we do have timespan in core it is referring to a timespan field and this is not. We have over usages of time span in core.Plus, we should open a follow up to convert all
datatypesto bedata types. Again there isdatatypesin core but the usage ofdata typesfar outweighs it (even in core.api.php).Comment #9
vegantriathleteComment #10
borisson_#9 fixes @alexpott's remarks, back to RTBC. We still need to file that followup though.
Comment #11
alexpottCommitted and pushed 91c29aea1d to 8.6.x and 6d4a847b0a to 8.5.x. Thanks!
Credited @msankhala and myself for reviews that directly influenced the patch.
Comment #14
vegantriathlete