Skip to content

Conversation

@stephaniewang526
Copy link
Contributor

No description provided.

@stephaniewang526 stephaniewang526 requested a review from a team August 10, 2020 18:19
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 10, 2020
@stephaniewang526 stephaniewang526 added the automerge Merge the pull request once unit tests and other checks pass. label Aug 10, 2020
@codecov
Copy link

codecov bot commented Aug 10, 2020

Codecov Report

Merging #667 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #667   +/-   ##
=========================================
  Coverage     81.49%   81.49%           
  Complexity     1226     1226           
=========================================
  Files            77       77           
  Lines          6220     6220           
  Branches        691      690    -1     
=========================================
  Hits           5069     5069           
  Misses          792      792           
  Partials        359      359           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcc44df...0bbb1c8. Read the comment docs.

@gcf-merge-on-green
Copy link

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@stephaniewang526 stephaniewang526 removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 10, 2020
@stephaniewang526 stephaniewang526 changed the title docs: update samples README.md and refactor SimpleQuery docs: update samples README.md Aug 11, 2020
@stephaniewang526 stephaniewang526 requested a review from lesv August 11, 2020 15:47
Copy link

@lesv lesv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still isn't the right way to execute this sample.

@stephaniewang526 stephaniewang526 merged commit 60d904b into master Aug 12, 2020
@stephaniewang526 stephaniewang526 deleted the samples-readme branch August 12, 2020 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants