This repository was archived by the owner on Dec 3, 2023. It is now read-only.
fix: removes flaky intent equivalence assertion #688
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neenu1995
approved these changes
Sep 3, 2021
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Sep 3, 2021
🤖 I have created a release \*beep\* \*boop\* --- ### [4.1.2](https://www.github.com/googleapis/java-dialogflow/compare/v4.1.1...v4.1.2) (2021-09-03) ### Bug Fixes * removes flaky intent equivalence assertion ([#688](https://www.github.com/googleapis/java-dialogflow/issues/688)) ([a965fb9](https://www.github.com/googleapis/java-dialogflow/commit/a965fb919fef422dd1a3fcea300f060706885fa7)) ### Dependencies * update dependency com.google.cloud:google-cloud-core to v2.1.2 ([#680](https://www.github.com/googleapis/java-dialogflow/issues/680)) ([4e6b60e](https://www.github.com/googleapis/java-dialogflow/commit/4e6b60ec28b4ce33b9f48b815304ab6e063f80f7)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.2.0 ([#681](https://www.github.com/googleapis/java-dialogflow/issues/681)) ([6708e3a](https://www.github.com/googleapis/java-dialogflow/commit/6708e3a1f1ab2431add1084b20a1c562ba934d61)) ### Documentation * clarified some LRO types ([#686](https://www.github.com/googleapis/java-dialogflow/issues/686)) ([84b863c](https://www.github.com/googleapis/java-dialogflow/commit/84b863cd166f3f5a0df353f381f9f03b2f6556b8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of how intents work in Dialogflow, asserting that the actual name of a resource matches the name of a newly created resource will not always be deterministic, especially if duplicate intents are added. This PR removes the offending assertion.
Fixes #623 ☕️