Skip to content
This repository was archived by the owner on Feb 13, 2026. It is now read-only.

feat: add support for Python 3.9, drop support for Python 3.5 - #55

Merged
tseaver merged 2 commits into
masterfrom
add-py39-support
Dec 12, 2020
Merged

tseaver merged 2 commits into
masterfrom
add-py39-support

Conversation

@tseaver

@tseaver tseaver commented Dec 11, 2020

Copy link
Copy Markdown
Contributor

No description provided.

@tseaver
tseaver requested review from a team, busunkim96, crwilcox and tswast December 11, 2020 20:03
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 11, 2020
@tseaver tseaver changed the title feat: add support for Python 3.9 feat: add support for Python 3.9, drop support for Python 3.5 Dec 11, 2020

@crwilcox crwilcox left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python_requires=">=2.7,!=3.0.*,!=3.1.*,!=3.2.*,!=3.3.*",

I am guessing this is staying this way to not mix the core/api-core dep reqs?

@tseaver

tseaver commented Dec 12, 2020

Copy link
Copy Markdown
Contributor Author

@crwilcox

python_requires=">=2.7,!=3.0.*,!=3.1.*,!=3.2.*,!=3.3.*",

I am guessing this is staying this way to not mix the core/api-core dep reqs?

We should probably update both of them and plan on releasing them in close proximity.

@tseaver

tseaver commented Dec 12, 2020

Copy link
Copy Markdown
Contributor Author

See: googleapis/python-api-core#114

Also, we should likely tweak the pin on google-api-core to match.

@tseaver
tseaver merged commit ddf7ce5 into master Dec 12, 2020
@tseaver
tseaver deleted the add-py39-support branch December 12, 2020 19:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants