fix(storage): remove expiration strict conversion (#106)

HemangChothani · web-flow · commit 9550dad6e63e · 2020-04-16T06:56:09.000Z
Fixes #105
diff --git a/google/cloud/storage/_signing.py b/google/cloud/storage/_signing.py
@@ -82,7 +82,7 @@ def get_signed_query_params_v2(credentials, expiration, string_to_sign):
     service_account_name = credentials.signer_email
     return {
         "GoogleAccessId": service_account_name,
-        "Expires": str(expiration),
+        "Expires": expiration,
         "Signature": signature,
     }
 
@@ -384,7 +384,7 @@ def generate_signed_url_v2(
         signature = _sign_message(string_to_sign, access_token, service_account_email)
         signed_query_params = {
             "GoogleAccessId": service_account_email,
-            "Expires": str(expiration),
+            "Expires": expiration_stamp,
             "Signature": signature,
         }
     else:
diff --git a/tests/unit/test__signing.py b/tests/unit/test__signing.py
@@ -252,7 +252,7 @@ def test_it(self):
 
         expected = {
             "GoogleAccessId": account_name,
-            "Expires": str(expiration),
+            "Expires": expiration,
             "Signature": base64.b64encode(sig_bytes),
         }
         self.assertEqual(result, expected)

Original file line number	Diff line number	Diff line change
`@@ -252,7 +252,7 @@ def test_it(self):`
`252`	`252`
`253`	`253`	`expected = {`
`254`	`254`	`"GoogleAccessId": account_name,`
`255`		`- "Expires": str(expiration),`
	`255`	`+ "Expires": expiration,`
`256`	`256`	`"Signature": base64.b64encode(sig_bytes),`
`257`	`257`	`}`
`258`	`258`	`self.assertEqual(result, expected)`