pgsql: Remove the "opaque" pseudo-type and associated compatibility hac

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Remove the "opaque" pseudo-type and associated compatibility hac
Date: 2020-03-05 20:49:09
Message-ID: [email protected]
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Remove the "opaque" pseudo-type and associated compatibility hacks.

A long time ago, it was necessary to declare datatype I/O functions,
triggers, and language handler support functions in a very type-unsafe
way involving a single pseudo-type "opaque". We got rid of those
conventions in 7.3, but there was still support in various places to
automatically convert such functions to the modern declaration style,
to be able to transparently re-load dumps from pre-7.3 servers.
It seems unnecessary to continue to support that anymore, so take out
the hacks; whereupon the "opaque" pseudo-type itself is no longer
needed and can be dropped.

This is part of a group of patches removing various server-side kluges
for transparently upgrading pre-8.0 dump files. Since we've had few
complaints about dropping pg_dump's support for dumping from pre-8.0
servers (commit 64f3524e2), it seems okay to now remove these kluges.

Discussion: https://postgr.es/m/[email protected]

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/bb03010b9f0766e10399174fe850b2506907c4e4

Modified Files
--------------
doc/src/sgml/datatype.sgml | 10 --
doc/src/sgml/ref/create_language.sgml | 10 --
doc/src/sgml/ref/create_trigger.sgml | 9 -
doc/src/sgml/ref/create_type.sgml | 12 --
src/backend/commands/functioncmds.c | 87 ---------
src/backend/commands/proclang.c | 25 +--
src/backend/commands/trigger.c | 23 +--
src/backend/commands/typecmds.c | 282 ++++++++++--------------------
src/backend/utils/adt/pseudotypes.c | 1 -
src/bin/pg_dump/pg_dump.c | 26 +--
src/bin/pg_dump/pg_dump.h | 2 -
src/include/catalog/catversion.h | 2 +-
src/include/catalog/pg_proc.dat | 10 +-
src/include/catalog/pg_type.dat | 4 -
src/include/commands/defrem.h | 2 -
src/pl/plperl/plperl.c | 4 +-
src/pl/plpgsql/src/pl_handler.c | 6 +-
src/pl/plpython/plpy_main.c | 4 +-
src/test/regress/expected/create_type.out | 43 +++--
src/test/regress/expected/opr_sanity.out | 2 +-
src/test/regress/sql/create_type.sql | 34 ++--
src/test/regress/sql/opr_sanity.sql | 2 +-
22 files changed, 168 insertions(+), 432 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2020-03-05 23:26:33 pgsql: Fix page-level checksum calculation in checksum_impl.h
Previous Message Magnus Hagander 2020-03-05 18:08:33 Re: pgsql: Revert "initdb: Change authentication defaults"