From: "ioquatix (Samuel Williams)" <noreply@...>
Date: 2021-11-09T01:19:12+00:00
Subject: [ruby-core:105978] [Ruby master Feature#18127] Ractor-local version of Singleton

Issue #18127 has been updated by ioquatix (Samuel Williams).


I appreciate the work that is being done here. However I am against introducing this feature and think that more discussion is required.

This change does not address the fact that `Singleton` remains broken when used with Ractor. Users should not need to care whether Ractor is used or not. A better solution is to fix `Singleton` so that it's Ractor compatible. This seems like leaky abstraction.

@matz are you happy with Ractor-specific interfaces spreading across Ruby code? especially given that other implementations of Ruby don't necessarily support it? 

1. Existing Ruby code is incompatible with Ractor.
2. New code that is compatible with Ractor is incompatible with old versions of CRuby and other implementations e.g. TruffleRuby and JRuby.

Based on this and other issues exposing Ractor specific code paths, I'm concerned too much of the implementation detail ins leaking into public interfaces and introduces many new complexities into user code.


----------------------------------------
Feature #18127: Ractor-local version of Singleton
https://bugs.ruby-lang.org/issues/18127#change-94524

* Author: rm155 (Rohit Menon)
* Status: Open
* Priority: Normal
----------------------------------------
**Background**
When the Singleton module (from the Singleton library) is included in a class, that class will have only one instance. Since the instance can only be in one Ractor at once, Singleton is not Ractor-compatible. For example, the following code would fail upon trying to access Example.instance in the Ractor:
``` ruby
class Example
  def initialize
    @value = 1
  end
end
Example.include Singleton

Ractor.new do
  Example.instance
end.take
#=> can not access instance variables of classes/modules from non-main Ractors (Ractor::IsolationError)
```

In some cases, this may be the desired behavior, as it may be important that the class truly have only one instance. However, in many other cases, it would be more convenient for the class to have one instance per Ractor.

**Proposal**
The proposal is to create a RactorLocalSingleton module that can be included instead of Singleton to make the instance Ractor-local.
Here is how RactorLocalSingleton might be used in the situation above:
``` ruby
class Example
  def initialize
    @value = 1
  end
end
Example.include RactorLocalSingleton

Ractor.new do
  Example.instance
end.take
```



**Discussion**
The advantage of creating RactorLocalSingleton is that classes could have Singleton-like behavior while being usable in Ractors. Since some libraries, such as Prime, currently rely on the Singleton module, this would enable those libraries to have more flexibility with Ractors.
The disadvantage of creating this module is that it supports the continued use of the Singleton design pattern, which is sometimes considered harmful. An alternative to RactorLocalSingleton might be to simply use Thread-local variables as Singleton instances. Here is how Thread-local variables might be used in the given situation:
``` ruby
class Example
  def initialize
    @value = 1
  end
end

Ractor.new do
  Thread.current[:Example] = Example.new
  Thread.current[:Example]
end.take
```


**Summary**
Classes that include Singleton are currently incompatible with Ractors. By instead including a new module RactorLocalSingleton, classes can have Singleton-like properties while being used in Ractors. However, this may perpetuate the use of the Singleton design pattern, and using Thread-local variables may be a preferable solution.




-- 
https://bugs.ruby-lang.org/

Unsubscribe: <mailto:ruby-core-request@ruby-lang.org?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>