From: "ayumin (Ayumu AIZAWA)" <ayumu.aizawa@...>
Date: 2012-05-05T23:17:23+09:00
Subject: [ruby-core:44891] [ruby-trunk - Bug #6405][Assigned]  Re: [ruby-cvs:42717] ryan:r35541 (trunk): Imported minitest 2.12.1 (r7323)


Issue #6405 has been updated by ayumin (Ayumu AIZAWA).

Status changed from Closed to Assigned

sorry, r35543 was wrong. ( reverted by r35544)

It should be fixed by mintiest side like as following:

--- a/lib/minitest/unit.rb
+++ b/lib/minitest/unit.rb
@@ -281,8 +281,8 @@ module MiniTest
 
     def assert_match matcher, obj, msg = nil
       msg = message(msg) { "Expected #{mu_pp matcher} to match #{mu_pp obj}" }
-      assert_respond_to matcher, :"=~"
-      matcher = Regexp.new Regexp.escape matcher if String === matcher
+      assert_respond_to obj, :"=~"
+      matcher = Regexp.new Regexp.escape matcher if String === matcher and String === obj
       assert matcher =~ obj, msg
     end
 
@@ -582,8 +582,8 @@ module MiniTest
 
     def refute_match matcher, obj, msg = nil
       msg = message(msg) {"Expected #{mu_pp matcher} to not match #{mu_pp obj}"}
-      assert_respond_to matcher, :"=~"
-      matcher = Regexp.new Regexp.escape matcher if String === matcher
+      assert_respond_to obj, :"=~"
+      matcher = Regexp.new Regexp.escape matcher if String === matcher and String === obj
       refute matcher =~ obj, msg
     end

----------------------------------------
Bug #6405:  Re: [ruby-cvs:42717] ryan:r35541 (trunk): Imported minitest 2.12.1 (r7323)
https://bugs.ruby-lang.org/issues/6405#change-26477

Author: naruse (Yui NARUSE)
Status: Assigned
Priority: Normal
Assignee: zenspider (Ryan Davis)
Category: 
Target version: 2.0.0
ruby -v: trunk


 After r35541, test-all fails as following:
 
   2) Error:
 test_equals_tilde(TestGemPlatform):
 TypeError: can't convert Gem::Platform to String
     /home/chkbuild/build/ruby-trunk/20120504T230101Z/ruby/test/rubygems/test_gem_platform.rb:210:in `test_equals_tilde'
     /home/chkbuild/build/ruby-trunk/20120504T230101Z/ruby/lib/test/unit.rb:633:in `block in _run_suites'
     /home/chkbuild/build/ruby-trunk/20120504T230101Z/ruby/lib/test/unit.rb:631:in `each'
     /home/chkbuild/build/ruby-trunk/20120504T230101Z/ruby/lib/test/unit.rb:631:in `_run_suites'
     /home/chkbuild/build/ruby-trunk/20120504T230101Z/ruby/lib/test/unit.rb:21:in `run'
     /home/chkbuild/build/ruby-trunk/20120504T230101Z/ruby/lib/test/unit.rb:682:in `run'
     /home/chkbuild/build/ruby-trunk/20120504T230101Z/ruby/lib/test/unit.rb:714:in `run'
     /home/chkbuild/build/ruby-trunk/20120504T230101Z/ruby/lib/test/unit.rb:718:in `run'
     ./test/runner.rb:15:in `<main>'
 
   3) Error:
 test_dir(TestGemInstaller):
 TypeError: can't convert Regexp to String
     /home/chkbuild/build/ruby-trunk/20120504T230101Z/ruby/test/rubygems/test_gem_installer.rb:1220:in `test_dir'
     /home/chkbuild/build/ruby-trunk/20120504T230101Z/ruby/lib/test/unit.rb:633:in `block in _run_suites'
     /home/chkbuild/build/ruby-trunk/20120504T230101Z/ruby/lib/test/unit.rb:631:in `each'
     /home/chkbuild/build/ruby-trunk/20120504T230101Z/ruby/lib/test/unit.rb:631:in `_run_suites'
     /home/chkbuild/build/ruby-trunk/20120504T230101Z/ruby/lib/test/unit.rb:21:in `run'
     /home/chkbuild/build/ruby-trunk/20120504T230101Z/ruby/lib/test/unit.rb:682:in `run'
     /home/chkbuild/build/ruby-trunk/20120504T230101Z/ruby/lib/test/unit.rb:714:in `run'
     /home/chkbuild/build/ruby-trunk/20120504T230101Z/ruby/lib/test/unit.rb:718:in `run'
     ./test/runner.rb:15:in `<main>'
 
 
 Why don't you run tests before commit.
 
 (2012/05/05 6:46), ryan@ruby-lang.org wrote:
 > ryan	2012-05-05 06:46:01 +0900 (Sat, 05 May 2012)
 > 
 >   New Revision: 35541
 > 
 >   http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=rev&revision=35541
 > 
 >   Log:
 >     Imported minitest 2.12.1 (r7323)
 > 
 >   Added files:
 >     trunk/test/minitest/metametameta.rb
 >   Modified files:
 >     trunk/ChangeLog
 >     trunk/lib/minitest/README.txt
 >     trunk/lib/minitest/autorun.rb
 >     trunk/lib/minitest/benchmark.rb
 >     trunk/lib/minitest/mock.rb
 >     trunk/lib/minitest/pride.rb
 >     trunk/lib/minitest/spec.rb
 >     trunk/lib/minitest/unit.rb
 >     trunk/test/minitest/test_minitest_benchmark.rb
 >     trunk/test/minitest/test_minitest_mock.rb
 >     trunk/test/minitest/test_minitest_spec.rb
 >     trunk/test/minitest/test_minitest_unit.rb
 
 -- 
 NARUSE, Yui  <naruse@airemix.jp>


-- 
http://bugs.ruby-lang.org/