From: "zenspider (Ryan Davis)" <redmine@...>
Date: 2012-05-19T06:50:10+09:00
Subject: [ruby-core:45131] [ruby-trunk - Bug #6405][Closed]  Re: [ruby-cvs:42717] ryan:r35541 (trunk): Imported minitest 2.12.1 (r7323)


Issue #6405 has been updated by zenspider (Ryan Davis).

Status changed from Assigned to Closed

I obviously ran the tests, as stated in my commit:

    Imported minitest 3.0.0 (r7435) w/ fixes for rubygems. 10955 tests, 2253343 assertions, 1 failures, 1 errors, 28 skips minus drb tests on x86_64-darwin11.3.0 and reviewed by drbrain

I have no failures in minitest, rubygems, or anything else that wasn't already failing on osx.

Your changes to test/minitest/*.rb are _not_ correct and fail on my side without changing my loadpath to include test/minitest. MRI tests run with -I. as you can see:

    ./miniruby -I./lib -I. -I.ext/common  ./tool/runruby.rb --extout=.ext  -- --disable-gems "./test/runner.rb" --ruby="./miniruby -I./lib -I. -I.ext/common  ./tool/runruby.rb --extout=.ext  -- --disable-gems" minitest

So my require lines were fine as-is and pass for me in svn's trunk and running on mri_trunk, 1.9.2-p320, 1.8.7-p249, 1.9.3-p194. With your change, my tests fail 100% w/o further changes to the load path:

    TOTAL RESULT = 4 failures out of 4
    Failed: 1.9.3-p194, mri_trunk, 1.8.7-p249, 1.9.2-p320

The only other require path that is valid would be "minitest/metametameta".

If you have a reproducible issue, please file a NEW ticket and provide proper details.

----------------------------------------
Bug #6405:  Re: [ruby-cvs:42717] ryan:r35541 (trunk): Imported minitest 2.12.1 (r7323)
https://bugs.ruby-lang.org/issues/6405#change-26705

Author: naruse (Yui NARUSE)
Status: Closed
Priority: Normal
Assignee: zenspider (Ryan Davis)
Category: 
Target version: 2.0.0
ruby -v: trunk


 After r35541, test-all fails as following:
 
   2) Error:
 test_equals_tilde(TestGemPlatform):
 TypeError: can't convert Gem::Platform to String
     /home/chkbuild/build/ruby-trunk/20120504T230101Z/ruby/test/rubygems/test_gem_platform.rb:210:in `test_equals_tilde'
     /home/chkbuild/build/ruby-trunk/20120504T230101Z/ruby/lib/test/unit.rb:633:in `block in _run_suites'
     /home/chkbuild/build/ruby-trunk/20120504T230101Z/ruby/lib/test/unit.rb:631:in `each'
     /home/chkbuild/build/ruby-trunk/20120504T230101Z/ruby/lib/test/unit.rb:631:in `_run_suites'
     /home/chkbuild/build/ruby-trunk/20120504T230101Z/ruby/lib/test/unit.rb:21:in `run'
     /home/chkbuild/build/ruby-trunk/20120504T230101Z/ruby/lib/test/unit.rb:682:in `run'
     /home/chkbuild/build/ruby-trunk/20120504T230101Z/ruby/lib/test/unit.rb:714:in `run'
     /home/chkbuild/build/ruby-trunk/20120504T230101Z/ruby/lib/test/unit.rb:718:in `run'
     ./test/runner.rb:15:in `<main>'
 
   3) Error:
 test_dir(TestGemInstaller):
 TypeError: can't convert Regexp to String
     /home/chkbuild/build/ruby-trunk/20120504T230101Z/ruby/test/rubygems/test_gem_installer.rb:1220:in `test_dir'
     /home/chkbuild/build/ruby-trunk/20120504T230101Z/ruby/lib/test/unit.rb:633:in `block in _run_suites'
     /home/chkbuild/build/ruby-trunk/20120504T230101Z/ruby/lib/test/unit.rb:631:in `each'
     /home/chkbuild/build/ruby-trunk/20120504T230101Z/ruby/lib/test/unit.rb:631:in `_run_suites'
     /home/chkbuild/build/ruby-trunk/20120504T230101Z/ruby/lib/test/unit.rb:21:in `run'
     /home/chkbuild/build/ruby-trunk/20120504T230101Z/ruby/lib/test/unit.rb:682:in `run'
     /home/chkbuild/build/ruby-trunk/20120504T230101Z/ruby/lib/test/unit.rb:714:in `run'
     /home/chkbuild/build/ruby-trunk/20120504T230101Z/ruby/lib/test/unit.rb:718:in `run'
     ./test/runner.rb:15:in `<main>'
 
 
 Why don't you run tests before commit.
 
 (2012/05/05 6:46), ryan@ruby-lang.org wrote:
 > ryan	2012-05-05 06:46:01 +0900 (Sat, 05 May 2012)
 > 
 >   New Revision: 35541
 > 
 >   http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=rev&revision=35541
 > 
 >   Log:
 >     Imported minitest 2.12.1 (r7323)
 > 
 >   Added files:
 >     trunk/test/minitest/metametameta.rb
 >   Modified files:
 >     trunk/ChangeLog
 >     trunk/lib/minitest/README.txt
 >     trunk/lib/minitest/autorun.rb
 >     trunk/lib/minitest/benchmark.rb
 >     trunk/lib/minitest/mock.rb
 >     trunk/lib/minitest/pride.rb
 >     trunk/lib/minitest/spec.rb
 >     trunk/lib/minitest/unit.rb
 >     trunk/test/minitest/test_minitest_benchmark.rb
 >     trunk/test/minitest/test_minitest_mock.rb
 >     trunk/test/minitest/test_minitest_spec.rb
 >     trunk/test/minitest/test_minitest_unit.rb
 
 -- 
 NARUSE, Yui  <naruse@airemix.jp>


-- 
http://bugs.ruby-lang.org/