From: Charlie Somerville <charlie@...>
Date: 2012-12-07T21:07:00+09:00
Subject: [ruby-core:50657] Re: [ruby-trunk - Bug #7528] CSV.== fails to check object type

--14dae93405fd6fa80704d041fa3d
Content-Type: text/plain; charset=UTF-8

=begin
It would probably be better to perform an (({is_a?})) check rather than
checking the class of the other object.
=end
On Dec 7, 2012 10:56 PM, "SteveW (Stephen Wattam)" <stephenwattam@gmail.com>
wrote:

>
> Issue #7528 has been updated by SteveW (Stephen Wattam).
>
>
> This seems to fix it:
>
> 478c478,479
> <       @row == other.row
> ---
> >       return @row == other.row if other.class == CSV::Row
> >       @row == other
>
> ----------------------------------------
> Bug #7528: CSV.== fails to check object type
> https://bugs.ruby-lang.org/issues/7528#change-34502
>
> Author: SteveW (Stephen Wattam)
> Status: Open
> Priority: Normal
> Assignee:
> Category:
> Target version:
> ruby -v: ruby 1.9.3p327 (2012-11-10 revision 37606) [x86_64-linux]
>
>
> CSV::Row's equality method presumes it is comparing another CSV::Row.  It
> fails when the object to be compared doesn't support the 'row' method:
>
> /usr/lib/ruby/1.9.1/csv.rb:478:in `==': undefined method `row' for
> nil:NilClass (NoMethodError)
>         from test.rb:7:in `<main>'
>
>
>
> --
> http://bugs.ruby-lang.org/
>
>

--14dae93405fd6fa80704d041fa3d
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<p>=3Dbegin<br>
It would probably be better to perform an (({is_a?})) check rather than che=
cking the class of the other object.<br>
=3Dend</p>
<div class=3D"gmail_quote">On Dec 7, 2012 10:56 PM, &quot;SteveW (Stephen W=
attam)&quot; &lt;<a href=3D"mailto:stephenwattam@gmail.com">stephenwattam@g=
mail.com</a>&gt; wrote:<br type=3D"attribution"><blockquote class=3D"gmail_=
quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1=
ex">
<br>
Issue #7528 has been updated by SteveW (Stephen Wattam).<br>
<br>
<br>
This seems to fix it:<br>
<br>
478c478,479<br>
&lt; =C2=A0 =C2=A0 =C2=A0 @row =3D=3D other.row<br>
---<br>
&gt; =C2=A0 =C2=A0 =C2=A0 return @row =3D=3D other.row if other.class =3D=
=3D CSV::Row<br>
&gt; =C2=A0 =C2=A0 =C2=A0 @row =3D=3D other<br>
<br>
----------------------------------------<br>
Bug #7528: CSV.=3D=3D fails to check object type<br>
<a href=3D"https://bugs.ruby-lang.org/issues/7528#change-34502" target=3D"_=
blank">https://bugs.ruby-lang.org/issues/7528#change-34502</a><br>
<br>
Author: SteveW (Stephen Wattam)<br>
Status: Open<br>
Priority: Normal<br>
Assignee:<br>
Category:<br>
Target version:<br>
ruby -v: ruby 1.9.3p327 (2012-11-10 revision 37606) [x86_64-linux]<br>
<br>
<br>
CSV::Row&#39;s equality method presumes it is comparing another CSV::Row. =
=C2=A0It fails when the object to be compared doesn&#39;t support the &#39;=
row&#39; method:<br>
<br>
/usr/lib/ruby/1.9.1/csv.rb:478:in `=3D=3D&#39;: undefined method `row&#39; =
for nil:NilClass (NoMethodError)<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 from test.rb:7:in `&lt;main&gt;&#39;<br>
<br>
<br>
<br>
--<br>
<a href=3D"http://bugs.ruby-lang.org/" target=3D"_blank">http://bugs.ruby-l=
ang.org/</a><br>
<br>
</blockquote></div>

--14dae93405fd6fa80704d041fa3d--