RESOLVED FIXED 89746
Replace isolate || bidi-override by isolate-override 
https://bugs.webkit.org/show_bug.cgi?id=89746
Summary Replace isolate || bidi-override by isolate-override
Ryosuke Niwa
Reported 2012-06-22 00:42:13 PDT
fantasai says: Change made, per WG resolution and me being convinced by trying to explain the issue to the WG. :) http://lists.w3.org/Archives/Public/www-style/2012May/0541.html http://dev.w3.org/csswg/css3-writing-modes/#unicode-bidi so we should update our implementation.
Attachments
Fixes the bug (18.29 KB, patch)
2012-08-20 14:00 PDT, Ryosuke Niwa 		leviw: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aharon (Vladimir) Lanin
Comment 1 2012-08-07 07:44:49 PDT
FYI, this has been done in Mozilla (https://bugzilla.mozilla.org/show_bug.cgi?id=774335)
Ryosuke Niwa
Comment 2 2012-08-20 14:00:52 PDT
Created attachment 159514 [details] Fixes the bug
Levi Weintraub
Comment 3 2012-08-20 14:06:41 PDT
Comment on attachment 159514 [details] Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=159514&action=review LGTM > Source/WebCore/css/CSSComputedStyleDeclaration.cpp:-1203 > -static PassRefPtr<CSSValue> renderUnicodeBidiFlagsToCSSValue(EUnicodeBidi unicodeBidi) > -{ > - switch (unicodeBidi) { > - case UBNormal: > - return cssValuePool().createIdentifierValue(CSSValueNormal); > - case Embed: > - return cssValuePool().createIdentifierValue(CSSValueEmbed); > - case Plaintext: > - return cssValuePool().createIdentifierValue(CSSValueWebkitPlaintext); > - case Override: > - return cssValuePool().createIdentifierValue(CSSValueBidiOverride); > - case Isolate: > - return cssValuePool().createIdentifierValue(CSSValueWebkitIsolate); > - case OverrideIsolate: > - { > - RefPtr<CSSValueList> list = CSSValueList::createSpaceSeparated(); > - list->append(cssValuePool().createIdentifierValue(CSSValueBidiOverride)); > - list->append(cssValuePool().createIdentifierValue(CSSValueWebkitIsolate)); > - return list; > - } > - } > - ASSERT_NOT_REACHED(); > - return 0; > -} > - Woohoo! > LayoutTests/fast/text/bidi-override-isolate.html:-13 > -<div><span style="direction: rtl; unicode-bidi: -webkit-isolate -webkit-isolate; unicode-bidi: isolate isolate; Was this just a copy-paste mistake?
Ryosuke Niwa
Comment 4 2012-08-20 14:07:52 PDT
(In reply to comment #3) > (From update of attachment 159514 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=159514&action=review > > > LayoutTests/fast/text/bidi-override-isolate.html:-13 > > -<div><span style="direction: rtl; unicode-bidi: -webkit-isolate -webkit-isolate; unicode-bidi: isolate isolate; > > Was this just a copy-paste mistake? No, it was testing the case where the same value appears twice.
Note You need to log in before you can comment on or make changes to this bug.