Chromium Main Console
| Legend: | Passed | Failed | Running | Exception |
Roll Chrome Android ARM32 Orderfile from 78pSs68rtDxNo3kh8... to tesrwSE1te_8hQnn-...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/orderfile-android-arm32-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Merge-Approval-Bypass: Chrome autoroller
Change-Id: I1b59d745dc43f8d3423bc5aa9b6efc64a46f9d21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6911071
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1510126}
Revert "[ios] Update the minimum required version of Xcode"
This reverts commit 81957bbfa19f9f02ee13a244b0026b2f5b3717c1.
Reason for revert: This breaks the iOS libfuzzer.
See https://ci.chromium.org/ui/p/chromium/builders/ci/Libfuzzer%20Upload%20iOS%20Catalyst%20Debug.
Bug: none
Original change's description:
> [ios] Update the minimum required version of Xcode
>
> It is now required to use Xcode 26.0+ to build Chrome on iOS, so
> update the documentation (and the assertion in chrome_build.gni)
> to avoid people asking why the build does not work for them.
>
> Bug: none
> Change-Id: I8325cb46da143a2e666c5c7cb7f06915bf7fa3e4
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6909893
> Reviewed-by: Gauthier Ambard <[email protected]>
> Commit-Queue: Sylvain Defresne <[email protected]>
> Commit-Queue: Gauthier Ambard <[email protected]>
> Auto-Submit: Sylvain Defresne <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1510106}
Bug: none
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I02b7adb19bb1f29e342ba6144882cd069d047a0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6909471
Commit-Queue: Rubber Stamper <[email protected]>
Auto-Submit: Jan Keitel <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Owners-Override: Jan Keitel <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1510125}
Roll DevTools Frontend from d3eb1d3b9b0e to 4e3ceb32af82 (1 revision)
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d3eb1d3b9b0e..4e3ceb32af82
2025-09-03 [email protected] Move ui/legacy/geometry into models/geometry
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: chromium:442509324
Change-Id: Ife4e330b3198fb87246116ab4c3a6c196bf089bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6910955
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1510124}
Roll Perfetto from 4f78c4ad8ce6 to 3b87105308b7 (1 revision)
https://chromium.googlesource.com/external/github.com/google/perfetto.git/+log/4f78c4ad8ce6..3b87105308b7
2025-09-03 [email protected] ui: Fix flow arrowhead rendering for vertical arrow separation (#2802)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: [email protected],[email protected]
Change-Id: I11ec5ca4defead612584eabc32a0724239aa7a55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6911203
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1510123}
Roll Amd64 AFDO from 141.0.7389.0_pre1509040_rc-r1-merged to 142.0.7391.0_pre1509560_rc-r1-merged
This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file go/crostc-bug.
Please note that, despite rolling to chrome/android, this profile is
used for both Linux and Android.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/afdo-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium Main: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Merge-Approval-Bypass: Chrome autoroller
Change-Id: I66489810afe85779eeecee5dbbc5ff5dfc6b6b77
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6910939
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1510122}
Roll Chrome Android ARM64 Orderfile from KYGgZ4pXCWUcU3pz3... to edtnwMoqCxxO9D_NZ...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/orderfile-android-arm64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Merge-Approval-Bypass: Chrome autoroller
Change-Id: Ib1e74419fb09422ef7b26cd212035e859cb0b44e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6910938
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1510121}
Disable flaky cronet ProxyTest
This is currently one of the top3 flaky tests in chromium.
Failure history: http://shortn/_MJqXzjiiCC
Bug: 442024094
Change-Id: I9e20364c086d3eece5faa8d761e4c4b2bb06568e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6908787
Commit-Queue: Jan Keitel <[email protected]>
Auto-Submit: Jan Keitel <[email protected]>
Owners-Override: Jan Keitel <[email protected]>
Reviewed-by: Christoph Schwering <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1510120}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1756857556-f755982f8679090bb72d0db75b169329126e7c55-9fb5b29e03bfb58b64746d20e1247ea7bb241ce0.profdata to chrome-win32-main-1756868061-d9f18b02c910d3d7df8cd5cf3f43901bb7cefe31-7bcebc2083eb4c550bc2cba55708778183744a39.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: [email protected]
Merge-Approval-Bypass: Chrome autoroller
Change-Id: I5c0c8677e773d89d57fbe6069fe78578adcff467
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6910923
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1510119}
Simplify strange use of SetBrowserClientForTesting().
There's no need to call this twice just to obtain the current value.
Bug: none
Change-Id: I50cdb49533bbd1945238fc888f0350bf36e38532
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6882456
Auto-Submit: Peter Kasting <[email protected]>
Reviewed-by: Guido Urdaneta <[email protected]>
Commit-Queue: Guido Urdaneta <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1510118}
Inform BubbleManager when a bubble is hidden
Bug: 432429605
Change-Id: I10c1b95993a4412e4846a905f9a6386c2ccc68b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6870816
Commit-Queue: Vidhan Jain <[email protected]>
Reviewed-by: Jan Keitel <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1510117}
Use BubbleManager to show VCN bubbles
BubbleManager uses a priority based algorithm to decide which bubble
has precedence to show if there are multiple bubbles waiting.
With this CL, the VCN bubbles are made to use the bubble manager to
show the bubble.
Bug: 432429605
Change-Id: I5e5613f3e2869a0b0192f68b5993b2f2d0c8bdd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6870119
Commit-Queue: Vidhan Jain <[email protected]>
Reviewed-by: Jan Keitel <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1510116}
Add MaySetUpBubble and QueueOrShowBubble to AutofillBubbleControllerBase
MaySetUpBubble tells the controller whether they should show the
incoming bubble or not.
QueueOrShowBubble calls the bubble manager to show the bubble if it is
enabled otherwise just shows it.
Bug: 432429605
Change-Id: If48c2ee01387b5316979ed7f1dd88c2f1ab66818
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6874107
Reviewed-by: Jan Keitel <[email protected]>
Commit-Queue: Vidhan Jain <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1510115}
Make GetPageActionIconType return std::optional
Autofill AI doesn't use the page action icon type and instead relies on
the address one for fallback since this method mandated returning a
PageActionIconType. With this CL, this method returns null for the
Autofill AI bubble.
Bug: 432429605
Change-Id: Ie0ec88d792e8e6399693f9e5c6d075a01f42a26a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6907748
Commit-Queue: Vidhan Jain <[email protected]>
Reviewed-by: Jan Keitel <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1510114}
Update and reenable two devtools tests
This also reverts commit 67a77865ab1c8511bb9040befb33dce38674d76f.
Bug: 407752215
Change-Id: Ibd7f9ec4d1bd675e498e6d781b16a73ac28f14f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6905423
Reviewed-by: Alex Rudenko <[email protected]>
Commit-Queue: Alex Rudenko <[email protected]>
Auto-Submit: Philip Pfaffe <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1510113}
[D3D12,AV1] Fix reference descriptors overwritten issue
Add the reference descriptors array as a member of AV1 delegate since
the `picture_params_` is reset for each encoding frame.
Bug: 40275246
Change-Id: Ib94371dbc57fbeb0fb08c8a789a8ea8212d843ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6880783
Reviewed-by: Eugene Zemtsov <[email protected]>
Commit-Queue: Yingying Ma <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1510112}
Settings: Refactor site_settings UIs to dedicated elements, part 3.
This is in preparation of moving these UIs from privacy_page.html to
privacy_page_index.html as part of the ongoing Settings re-architecture.
The refactoring has been facilitated by using a local script (see
crrev.com/c/4492155).
Bug: 40719916
Change-Id: Icd4c365deebeedb78bdbe67686ac305eb48cf670
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6908361
Commit-Queue: Demetrios Papadopoulos <[email protected]>
Reviewed-by: Rainhard Findling <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1510111}
Reland "Fix double counting num_tracked_windows"
This reverts commit 9fb5b29e03bfb58b64746d20e1247ea7bb241ce0.
Reason for revert: the failed test requires DCHECK. Updated the test to skip if not enabled.
Bug: 435754476
Original change's description:
> Revert "Fix double counting num_tracked_windows"
>
> This reverts commit b1c9546fda0f18e517cc32a69ae5946a92151663.
>
> Reason for revert: The added test
> WindowOcclusionTrackerTest.DoNotCountTwice
> is failing on
> https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests
> https://ci.chromium.org/ui/p/chromium/builders/ci/chromeos-amd64-generic-rel-gtest
>
> First failing builds:
> https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests/165621/overview
> https://ci.chromium.org/ui/p/chromium/builders/ci/chromeos-amd64-generic-rel-gtest/26527/overview
>
> Bug: 435754476
> Original change's description:
> > Fix double counting num_tracked_windows
> >
> > WindowOcclusionTracker (WOT) may count the window twice if the Tracking
> > starts in WindowObserver::OnParentChanged (there may be other cases)
> > 1) It's increemented upon Track() because it has a root window. [1]
> > 2) Then incremented again in OnWindowAddedToRootWindow[2]
> >
> > This leave WOT in inconsistent state and leaves
> > WindowTreeHostObserver, which leads to CHECK failure later.
> >
> > This CL fixes by
> > 1) Observe WindowTreeHost (WTH) if not observed yet.
> > 2) Unobserve WHT if there is no tracked window that belongs to
> > after a window is being removed from the tree.
> >
> > This CL keeps num_tracked_windows_ for verification purpose (assumes
> > existing code base do not have such use case). I'll remove it before
> > m142 branch cut unless this causes an issue.
> >
> > [1] https://source.chromium.org/chromium/chromium/src/+/main:ui/aura/window.cc;drc=54e79869abfe54e3f4db0298641659272f6f7ccb;l=563
> > [2] https://source.chromium.org/chromium/chromium/src/+/main:ui/aura/window.cc;drc=54e79869abfe54e3f4db0298641659272f6f7ccb;l=567
> >
> > Bug: 435754476
> > Test: covered by unittest.
> > Change-Id: Ia9e4fb3ae0a2aabae1f291de94e8130d8d174f4c
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6871198
> > Reviewed-by: Zoraiz Naeem <[email protected]>
> > Reviewed-by: Eliot Courtney <[email protected]>
> > Commit-Queue: Mitsuru Oshima <[email protected]>
> > Cr-Commit-Position: refs/heads/main@{#1509922}
>
> Bug: 435754476
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Change-Id: Iee15e1a60abb3ecf51fc65b881c8e34473b5bf1c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6909978
> Commit-Queue: Rubber Stamper <[email protected]>
> Auto-Submit: Hiroshige Hayashizaki <[email protected]>
> Owners-Override: Hiroshige Hayashizaki <[email protected]>
> Bot-Commit: Rubber Stamper <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1509947}
Bug: 435754476
Change-Id: I252bfd3529bc774a13f86e19601f6accf3d86526
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6909948
Commit-Queue: Mitsuru Oshima <[email protected]>
Reviewed-by: Zoraiz Naeem <[email protected]>
Reviewed-by: Eliot Courtney <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1510110}
Retire `kRecursivelyMergeSingleTokenSubset` and related code.
This merge mode complicates the codebase while not being used anywhere.
Bug: 437318231
Change-Id: I5850fe4e0284859bf447fd3157f1df4208f9a20a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6904262
Reviewed-by: Karol Sygiet <[email protected]>
Commit-Queue: Piotr Domaradzki <[email protected]>
Reviewed-by: Norge Vizcay <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1510109}
[ios] Add RegisterProfilePrefs() to ProfileKeyedServiceFactoryIOS
To remove the references to BrowserState (and make it clear that all
code in //ios/chrome/browser should use ProfileIOS*) add a method
RegisterProfilePrefs(...) to ProfileKeyedServiceFactoryIOS.
If overloaded, it is used to register the prefs. Otherwise the code
still use RegisterBrowserStatePrefs(...) which is still the method
that sub-classes override (they will be converted in followup CLs).
Bug: 436484783
Change-Id: I896e2fa9f321b605629124b7a53b00b6c3caf3c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6903972
Commit-Queue: Sylvain Defresne <[email protected]>
Reviewed-by: Federica Germinario <[email protected]>
Auto-Submit: Sylvain Defresne <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1510108}
Only disable privacy page index settings test on dbg builds
Bug: 442545295
Change-Id: I7aebf8462bb59cf000bfb2698972f40e09522ca2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6909491
Commit-Queue: Jan Keitel <[email protected]>
Commit-Queue: Demetrios Papadopoulos <[email protected]>
Reviewed-by: Rainhard Findling <[email protected]>
Commit-Queue: Rainhard Findling <[email protected]>
Auto-Submit: Jan Keitel <[email protected]>
Reviewed-by: Demetrios Papadopoulos <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1510107}
[ios] Update the minimum required version of Xcode
It is now required to use Xcode 26.0+ to build Chrome on iOS, so
update the documentation (and the assertion in chrome_build.gni)
to avoid people asking why the build does not work for them.
Bug: none
Change-Id: I8325cb46da143a2e666c5c7cb7f06915bf7fa3e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6909893
Reviewed-by: Gauthier Ambard <[email protected]>
Commit-Queue: Sylvain Defresne <[email protected]>
Commit-Queue: Gauthier Ambard <[email protected]>
Auto-Submit: Sylvain Defresne <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1510106}
[Signin] Use OAuthConsumerId in components/enterprise
Bug: 425896213
Change-Id: Ia2222539c8835114b284002586438c3eee283c6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6903232
Reviewed-by: Julian Pastarmov <[email protected]>
Reviewed-by: Ryan Sultanem <[email protected]>
Commit-Queue: Liza Bipin <[email protected]>
Reviewed-by: Yann Dago <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1510105}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1756857556-5add76cd18de14e46c98063b554b904bb35d7131-9fb5b29e03bfb58b64746d20e1247ea7bb241ce0.profdata to chrome-win64-main-1756868061-ab262816e58af146d9eba1086faf5eebf15c5e9a-7bcebc2083eb4c550bc2cba55708778183744a39.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: [email protected]
Merge-Approval-Bypass: Chrome autoroller
Change-Id: Id53e227cd8e4b9125734835c5048ced9f9183427
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6910556
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1510104}
Import wpt@8f26491d1de0d0fa3b33229c88e5e9d883e57d28
https://github.com/web-platform-tests/wpt/compare/644763759...8f26491d1
Using wpt-import in Chromium f42f23cca0f8c22a4612782f2e59fe39e9bfc20a.
With Chromium commits locally applied on WPT:
830f9cf847 "[anchor] Keep anchored elements within their [...]
415a9b9632 "[anchor] Lay out an OOF with anchors before [...]
613d65b51f "[anchor] Convert 3 multicol tests to reftests."
Note to gardeners: This CL imports external tests and adds expectations
for those tests; if this CL is large and causes a few new failures,
please fix the failures by adding new lines to TestExpectations rather
than reverting. See:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md
NOAUTOREVERT=true
[email protected]
No-Export: true
Validate-Test-Flakiness: skip
Cq-Include-Trybots: luci.chromium.try:linux-blink-rel
Change-Id: I44f4c6c2c0491e59026e713f153b5998a081e099
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6907188
Commit-Queue: Rubber Stamper <[email protected]>
Auto-Submit: WPT Autoroller <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1510103}
[Autofill] Set ML heuristic types in update_cache()
This CL moves setting the ML types of AutofillFields from the
receive_predictions() callback to the final callback, update_cache().
Bug: 427787155, 40232021
Change-Id: I8dcc379410941df182ec7eb391968bf4b2a52b70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6904491
Reviewed-by: Jan Keitel <[email protected]>
Commit-Queue: Christoph Schwering <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1510102}
Reset browser color scheme upon signout if no local theme pref existed
This scenario should mostly happen for users who batch upload their
local theme to the account and then sign out. Upon signout, these users
have no local theme saved anymore and thus their theme is set to the
default. However, the default theme does not reset the browser color
scheme. This might leak the account data info and is best to be reset to
the system color scheme.
Bug: 433935323,442592525
Change-Id: Ic206ef07c1e9713b832bb4328419e81c85ed884c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6905411
Reviewed-by: Tibor Goldschwendt <[email protected]>
Commit-Queue: Ankush Singh <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1510101}
[ios] Rename +registerBrowserStatePrefs: to +registerProfilePrefs:
This converts the files in //ios/chrome/browser/bookmarks.
Bug: 436484783
[ios] Add RegisterProfilePrefs() to ProfileKeyedServiceFactoryIOS
To remove the references to BrowserState (and make it clear that all
code in //ios/chrome/browser should use ProfileIOS*) add a method
RegisterProfilePrefs(...) to ProfileKeyedServiceFactoryIOS.
If overloaded, it is used to register the prefs. Otherwise the code
still use RegisterBrowserStatePrefs(...) which is still the method
that sub-classes override (they will be converted in followup CLs).
Bug: 436484783
Change-Id: I44d9e4bc02fa219d2977c4d4bd120a137cd505c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6905410
Commit-Queue: Jérôme Lebel <[email protected]>
Auto-Submit: Sylvain Defresne <[email protected]>
Reviewed-by: Jérôme Lebel <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1510100}
[Autofill] Refactor AsyncContext and async ML calls
This CL refactors the asynchronous ML model calls in AutofillManager
in two ways:
1. It restructures ApplyMlModel().
Old behaviour: ApplyMlModel() was called twice, once synchronously
and once asynchronously, to run the Autofill and the PWM models,
respectively. The second call was done by the first one.
New behaviour: RunMlModels() is called asynchronously. It
triggers two asynchronous model runs, for Autofill and PWM.
Motivation: The threading through of the AsyncContext is easier to
follow with new structure. The new name is to avoid confusion: after
the followup CLs, RunMlModels() won't "apply" the predictions to the
FormStructure (that'll be done in ParseFormsAsyncCommon()).
2. It threads through an AsyncContext through all asynchronous calls.
Old behaviour: Only the heuristics used AsyncContext.
Future behaviour: Also the ML predictions will be stored in
AsyncContext. AsyncContext::current_stage indicates whether we're
running the Autofill or the PWM model.
Motivation: In a followup CL, the final response callback
(update_cache()) will apply the heuristic and ML predictions to
the FormStructure.
Bug: 427787155, 40232021
Change-Id: I573edb00f927094dff582e1c5f33906708e01384
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6903967
Reviewed-by: Jan Keitel <[email protected]>
Commit-Queue: Christoph Schwering <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1510099}
Roll Arm AFDO from 141.0.7389.0_pre1509040_rc-r1-merged to 142.0.7391.0_pre1509560_rc-r1-merged
This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file go/crostc-bug.
Please note that, despite rolling to chrome/android, this profile is
used for both Linux and Android.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/afdo-arm-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium Main: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Merge-Approval-Bypass: Chrome autoroller
Change-Id: If937dca60f2a9a363944afc4130bcb985658205a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6911068
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1510098}
[text-emphasis] Allow specific punctuation characters
This CL implements an exception list that allows a specific set of
punctuation characters to receive CSS `text-emphasis`.
This CL cannot fix
`css/css-text-decor/text-emphasis-punctuation-3.html`, because Blink
renders text-emphasis differently from ruby, which the test uses as its
reference. Related issue is https://crbug.com/40851160
Spec:
https://drafts.csswg.org/css-text-decor/#text-emphasis-style-property
Bug: 359420112
Change-Id: I1b92b79e5f42acb1ce4240f49daab5675f6a5a9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6904710
Reviewed-by: Koji Ishii <[email protected]>
Commit-Queue: Minseong Kim <[email protected]>
Reviewed-by: Kent Tamura <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1510097}
Fix incorrect reference to BrowserStateKeyedServiceFactory
The factories classes in //chrome/browser inherits from either
ProfileKeyedServiceFactor or BrowserContextKeyedServiceFactory
but not BrowserStateKeyedServiceFactory.
Fix the "// BrowserContextKeyedServiceFactory implementation"
comments to refer to the correct class.
Bug: none
Change-Id: I4cec185b5cb4f7c1b4ef2603aa2f1931c7d59e14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6911181
Reviewed-by: David Roger <[email protected]>
Auto-Submit: Sylvain Defresne <[email protected]>
Commit-Queue: Sylvain Defresne <[email protected]>
Commit-Queue: David Roger <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1510096}
Roll Chrome Android ARM64 PGO Profile
Roll Chrome Android ARM64 PGO profile from chrome-android64-main-1756871886-e1423b4f294000a37d5d1a393e5719a046a1d69e-4694dccaa905e832c96bf92fd5a327412935bb70.profdata to chrome-android64-main-1756881620-1de956ef9d1d0c47ad42f212797b1f9fa3e24821-622055f7eb666ad9ec2af68f077c3c2149fa19e9.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-android-arm64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Merge-Approval-Bypass: Chrome autoroller
Change-Id: I54080e4b08876773fe1c5b5e8d55a6499827c435
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6911088
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1510095}
Make the modulemap for all platforms generated by gn
By making it generated, we can allow users to override the sysroot
directory. This is relevant for ChromeOS, which uses cros-sdk to obtain
a toolchain.
It is also relevant for windows, as each new version of the windows
sysroot has its hash in the path, and this will allow the modulemap to
work between updates.
Bug: 442479236
Change-Id: I6a6a6964e8f34b12fae20e095580a59bbca8b863
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6904866
Reviewed-by: Takuto Ikuta <[email protected]>
Commit-Queue: Matt Stark <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1510094}
Roll JetStream main from 4c0b48a3c380 to 724cf7c2466d (1 revision)
https://chromium.googlesource.com/external/github.com/WebKit/JetStream.git/+log/4c0b48a3c380..724cf7c2466d
2025-09-03 [email protected] Remove unused scripts (#174)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/jetstream-main-chromium
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected],[email protected]
Change-Id: I4c2e58bca2d6fe8eb73da817fdb9a74acc01e2a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6910879
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1510093}
[tab-size] Fallback font if space glyph doesn't exists
This CL fixes a font fallback logic by ensuring the font contains the
space glyph when computing tab-size.
Bug: 442623894
Change-Id: Ia7863084f9b0f83477e7efcdcefaa2c9b9864a53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6903719
Reviewed-by: Koji Ishii <[email protected]>
Reviewed-by: Kent Tamura <[email protected]>
Commit-Queue: Minseong Kim <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1510092}
Disable flaky RFH test
Sample failing build:
https://ci.chromium.org/ui/p/chromium/builders/ci/Mac13%20Tests/32779/overview
Bug: 442684241
Change-Id: I2035a75ba4a3b570e2caaa0b16e2b3976e2d9fd4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6909489
Reviewed-by: Dominic Battré <[email protected]>
Owners-Override: Jan Keitel <[email protected]>
Auto-Submit: Jan Keitel <[email protected]>
Commit-Queue: Jan Keitel <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1510091}
Roll DevTools Frontend from 1078b4549e24 to d3eb1d3b9b0e (1 revision)
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1078b4549e24..d3eb1d3b9b0e
2025-09-03 [email protected] Support search on the new devtools-tree component
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: chromium:407752215,chromium:436136172
Change-Id: I150bda421212b360c048233cdf69ad57d3eb80b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6911087
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1510090}
Roll androidx from CcB-WuYHGtGWIfeXm... to u5m6UpIUPRwlbKfac...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/androidx-chromium
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:android-internal-binary-size;luci.chrome.try:android-internal-rel;luci.chrome.try:test-emulator
Tbr: [email protected]
Change-Id: Ica7e690ac081fad3fa806d117d94b918d30df732
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6911102
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1510089}
[iOS] Moves snackbar animation out of the coordinator
Bug: 438409021, 436248990
Change-Id: Iecd4a313226e8803612d381695e9f31cc553bc24
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6903974
Reviewed-by: Gauthier Ambard <[email protected]>
Commit-Queue: Ewann Pellé <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1510088}
[IOS RM] Tests that Reading mode view is not auto translated.
Add a test for crrev.com/c/6905922
Bug: 442376154
Change-Id: I079d3b2848a16ddf90a42d0dc3410948f16af468
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6905449
Reviewed-by: Gauthier Ambard <[email protected]>
Commit-Queue: Olivier Robin <[email protected]>
Reviewed-by: Nohemi Fernandez <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1510087}
[signin] Support signin pattern for signin rather than sync
This CL adds support for the signin pattern in AccountsPolicyManager and
in the profile menu.
In the profile menu, if the current web account is not allowed to sign
in, then other accounts may be offered. If there is no other eligible
account, then a generic non-personalized button is shown.
Future CLs will add support in other features, such as the signin promo
bubbles.
Bug: 430004744, 360379437
Change-Id: I1dd8fa87e1aad3790a95d8ed80e4d73ba7f81252
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6878965
Reviewed-by: Yann Dago <[email protected]>
Commit-Queue: David Roger <[email protected]>
Reviewed-by: Amelie Schneider <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1510086}
Roll Chrome Android ARM32 PGO Profile
Roll Chrome Android ARM32 PGO profile from chrome-android32-main-1756857556-2516e97c7ef286be400ad0e583a2628faa4ebd3f-9fb5b29e03bfb58b64746d20e1247ea7bb241ce0.profdata to chrome-android32-main-1756879124-200e7459337e5f1b39c9bfafc2fadb47c4cd79ec-87c19a36e4f40aeb3928f4bb19aebb17f3a745bd.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-android-arm32-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Merge-Approval-Bypass: Chrome autoroller
Change-Id: I7de90f9f45655b6d100b8fea9b87685d83065fc0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6910877
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1510085}
FitText: Add ComputeAdditionalPaintTimeScale()
It's called from MeasurePerBlockScale() to compute an additional
paint-time scale of the widest line.
This CL has no behavior changes due to a disabled runtime flag.
Bug: 417306102
Change-Id: Iab3778ae7f650acd5fd3fcb34b14a3ee42b085aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6904833
Commit-Queue: Kent Tamura <[email protected]>
Auto-Submit: Kent Tamura <[email protected]>
Commit-Queue: Koji Ishii <[email protected]>
Reviewed-by: Koji Ishii <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1510084}
Textarea: Fix zero-height line after text removal with InsertText
When InsertText command removed text content, an empty Text node
remained and it produced a zero-height line. Users couldn't place
the text caret on such line.
This CL fixes the problem by removing such empty Text node after
editing commands.
Bug: 442551790
Change-Id: I986a36fa8f6a3bf918f2589a2573c79ed83c8bbe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6911021
Reviewed-by: Koji Ishii <[email protected]>
Auto-Submit: Kent Tamura <[email protected]>
Commit-Queue: Koji Ishii <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1510083}
Update wtf/text/README.md for blink::StrCat()
This CL has no behavior changes.
Bug: 419595599
Change-Id: I86e827a7613e8c9f6ab67ccd8118b7f63c1b6a19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6909351
Commit-Queue: Fredrik Söderquist <[email protected]>
Auto-Submit: Kent Tamura <[email protected]>
Reviewed-by: Fredrik Söderquist <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1510082}
[iOS] Split DownloadRecordService into base + impl pattern
Create abstract base class and move implementation to separate
class following iOS Chrome architectural conventions. This
improves testability and follows patterns used by other service
classes.
- Abstract DownloadRecordService base class with pure virtual
interface
- DownloadRecordServiceImpl with all concrete implementation
- Update factory and tests accordingly
- No functional changes
Bug: none
Change-Id: I2a8c8445c50a31546b2b8022124f4036a6e06abe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6904872
Reviewed-by: Ran Sun <[email protected]>
Commit-Queue: weipeng li <[email protected]>
Reviewed-by: Ewann Pellé <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1510081}
Remove all WTF-prefixed aliases
This CL has no behavior changes.
Bug: 422768753
Change-Id: Ic387df5f14e7543f19b04c736bd8bc0a9d7a40e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6910097
Commit-Queue: Koji Ishii <[email protected]>
Auto-Submit: Kent Tamura <[email protected]>
Reviewed-by: Koji Ishii <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1510080}
Disable flaky PrivacyPageIndex test
Test history: http://shortn/_Ov66FN0vws
Bug: 442545295
Change-Id: I3a29a6af1a7dd8aeb74d25016ab4cdca3ba7ebba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6909892
Commit-Queue: Florian Leimgruber <[email protected]>
Auto-Submit: Jan Keitel <[email protected]>
Commit-Queue: Jan Keitel <[email protected]>
Reviewed-by: Florian Leimgruber <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1510079}
[Blink] Eliminate no-longer-relevant comment
This enum is no longer used in metrics following [1].
[1] https://chromium-review.googlesource.com/c/chromium/src/+/6905946
Change-Id: I15b793c97ab3a3fe52afb29faee77d82f0cef97e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6908424
Reviewed-by: Ian Clelland <[email protected]>
Commit-Queue: Colin Blundell <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1510078}
[webui browser] Hide & show non-global side panel entry on tab switch
We add logic to hide and show the side panel, if applicable, on tab
switch. Note that the global side panel entries (e.g. bookmarks, reading
list) behave differently than the rest.
This is part of the WebUIBrowser project.
Bug: 439850993,393144165
Change-Id: I43335eb9f507a75f179eaedc5c25374f976e4a6c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6909672
Commit-Queue: Cammie Smith Barnes <[email protected]>
Reviewed-by: Keren Zhu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1510077}