| commit | c32a70ada73bd1290d61b26e4df567c0e4850f4f | [log] [tgz] |
|---|---|---|
| author | dpapad <[email protected]> | Mon Aug 04 05:20:07 2025 |
| committer | Chromium LUCI CQ <[email protected]> | Mon Aug 04 05:20:07 2025 |
| tree | 151333e1271e4b7be5829b0610294a913e19aac8 | |
| parent | f171c1c9c3c54abc01d22c316b88fa07fe5e96e9 [diff] |
Settings: Deflake SettingsTest.SettingsMain. The tests were flaking because there wasn't a reliable signal to wait for after currentRouteChanged() calls to signify that cr-view-manager had finished transitioning to the newly displayed view. The test code was calling flushTasks() which was not sufficient. Fixed by exposed a whenViewSwitchingDone() method which returns a Promise that can reliably signal when the test can make assertions. A similar approach is being used at https://crrev.com/c/6784912 for the same reason. Bug: 435560735 Change-Id: I2eb3a5f0b6ee01f074578ce0cd0968093c290a98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6813306 Commit-Queue: John Lee <[email protected]> Auto-Submit: Demetrios Papadopoulos <[email protected]> Reviewed-by: John Lee <[email protected]> Cr-Commit-Position: refs/heads/main@{#1496137}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.