Remove some more OS_CHROMEOS from browser.

Remove some more OS_CHROMEOS from browser.

BUG=none
TEST=none
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137200

[Ben Goodger (Google), 2012-05-15 17:58:20]

This does two things:

- moves invocation of keyboard overlay to ash (and thus removes a bunch of
wiring in Browser/BrowserWindow/BrowserView)
- removes some cros stuff that related to the X wm from page info bubble.

[sky, 2012-05-15 18:03:12]

I think you want GetDefaultProfileOrOffTheRecord and then LGTM

[mazda, 2012-05-15 18:15:26]

Hi Ben,

Thank you for doing this.
Could you add 121999 (http://crbug.com/121999) to the BUG line?

[mazda, 2012-05-15 18:36:43]

https://chromiumcodereview.appspot.com/10377114/diff/15006/chrome/browser/ui/...
File chrome/browser/ui/views/keyboard_overlay_dialog_view.cc (right):

https://chromiumcodereview.appspot.com/10377114/diff/15006/chrome/browser/ui/...
chrome/browser/ui/views/keyboard_overlay_dialog_view.cc:77:
target_->AcceleratorPressed(accelerator);
This line is supposed to handle browser accelerators so that browser
accelerators take effect while the keyboard overlay is shown
(http://crbug.com/122070).
So we need to pass BrowserView as |target _| instead of AcceleratorController.

[Ben Goodger (Google), 2012-05-15 19:45:45]

Well, some of the shortcuts surely affect the shell, too (not just the BV).
Won't the accelerator controller pass unhandled accelerators to the focused
browser window?

-Ben

On Tue, May 15, 2012 at 11:36 AM, <[email protected]> wrote:

>
> https://chromiumcodereview.**appspot.com/10377114/diff/**
>
15006/chrome/browser/ui/views/**keyboard_overlay_dialog_view.**cc<https://chromiumcodereview.appspot.com/10377114/diff/15006/chrome/browser/ui/views/keyboard_overlay_dialog_view.cc>
> File chrome/browser/ui/views/**keyboard_overlay_dialog_view.**cc (right):
>
> https://chromiumcodereview.**appspot.com/10377114/diff/**
> 15006/chrome/browser/ui/views/**keyboard_overlay_dialog_view.**
>
cc#newcode77<https://chromiumcodereview.appspot.com/10377114/diff/15006/chrome/browser/ui/views/keyboard_overlay_dialog_view.cc#newcode77>
> chrome/browser/ui/views/**keyboard_overlay_dialog_view.**cc:77:
> target_->AcceleratorPressed(**accelerator);
> This line is supposed to handle browser accelerators so that browser
> accelerators take effect while the keyboard overlay is shown
> (http://crbug.com/122070).
> So we need to pass BrowserView as |target _| instead of
> AcceleratorController.
>
>
https://chromiumcodereview.**appspot.com/10377114/<https://chromiumcodereview...
>

[mazda, 2012-05-15 19:57:38]

On 2012/05/15 19:45:45, Ben Goodger (Google) wrote:
> Well, some of the shortcuts surely affect the shell, too (not just the BV).
> Won't the accelerator controller pass unhandled accelerators to the focused
> browser window?
> 
> -Ben

That's right, and it is another issue I have to fix (http://crbug.com/117365).