Change most content::URLFetcher references to net::URLFetcher

Change most content::URLFetcher references to net::URLFetcher

The only remaining use of content::URLFetcher is content::URLFetcher::Create.

Make content::URLFetcher not inherit from net::URLFetcher.

Also make code that directly create URLFetcherImpl instead call content::URLFetcher::Create.

BUG=118220
TEST=
[email protected],[email protected],[email protected],[email protected]

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138443

[akalin, 2012-05-23 00:19:27]

+wtc for review

All changes are mechanical.

[wtc, 2012-05-23 01:34:00]

Patch set 2 LGTM.  The nits I pointed out below may be in
multiple files.  They may not be worth fixing.

https://chromiumcodereview.appspot.com/10412050/diff/8001/chrome/common/net/g...
File chrome/common/net/gaia/oauth2_api_call_flow_unittest.cc (right):

https://chromiumcodereview.appspot.com/10412050/diff/8001/chrome/common/net/g...
chrome/common/net/gaia/oauth2_api_call_flow_unittest.cc:63: net::URLFetcher*
(int id,

This file has a
    using net::URLFetcher;
statement, so it'd be better to omit net::. See for
example line 65.

https://chromiumcodereview.appspot.com/10412050/diff/8001/chrome/service/clou...
File chrome/service/cloud_print/cloud_print_url_fetcher.h (right):

https://chromiumcodereview.appspot.com/10412050/diff/8001/chrome/service/clou...
chrome/service/cloud_print/cloud_print_url_fetcher.h:13: #include
"content/public/common/url_fetcher.h"

We should not need to include this header now, right?

https://chromiumcodereview.appspot.com/10412050/diff/8001/content/browser/geo...
File content/browser/geolocation/network_location_request.h (right):

https://chromiumcodereview.appspot.com/10412050/diff/8001/content/browser/geo...
content/browser/geolocation/network_location_request.h:19: class URLFetcher;

Delete this forward declaration, or rather, forward
declare net::URLFetcher instead?

[commit-bot: I haz the power, 2012-05-23 03:28:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/10412050/8002

[commit-bot: I haz the power, 2012-05-23 03:29:17]

Presubmit check for 10412050-8002 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    content/public
    chrome/browser/policy
    chrome/browser/ui/intents
    chrome/browser/component_updater
    chrome/browser/ui/webui/ntp
    chrome/browser/search_engines
    content/browser/geolocation
    chrome/browser/profiles
    content/browser/speech
    content/test

Presubmit checks took 6.1s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
[email protected]!

[akalin, 2012-05-23 04:33:09]

Committing after trybots

http://codereview.chromium.org/10412050/diff/8001/chrome/common/net/gaia/oaut...
File chrome/common/net/gaia/oauth2_api_call_flow_unittest.cc (right):

http://codereview.chromium.org/10412050/diff/8001/chrome/common/net/gaia/oaut...
chrome/common/net/gaia/oauth2_api_call_flow_unittest.cc:63: net::URLFetcher*
(int id,
On 2012/05/23 01:34:01, wtc wrote:
> 
> This file has a
>     using net::URLFetcher;
> statement, so it'd be better to omit net::. See for
> example line 65.

Done.  I think I got the other instances, too.

http://codereview.chromium.org/10412050/diff/8001/chrome/service/cloud_print/...
File chrome/service/cloud_print/cloud_print_url_fetcher.h (right):

http://codereview.chromium.org/10412050/diff/8001/chrome/service/cloud_print/...
chrome/service/cloud_print/cloud_print_url_fetcher.h:13: #include
"content/public/common/url_fetcher.h"
On 2012/05/23 01:34:01, wtc wrote:
> 
> We should not need to include this header now, right?

True.  But we do need to include net/url_request/url_fetcher.h for the
RequestCookies typedef.

http://codereview.chromium.org/10412050/diff/8001/content/browser/geolocation...
File content/browser/geolocation/network_location_request.h (right):

http://codereview.chromium.org/10412050/diff/8001/content/browser/geolocation...
content/browser/geolocation/network_location_request.h:19: class URLFetcher;
On 2012/05/23 01:34:01, wtc wrote:
> 
> Delete this forward declaration, or rather, forward
> declare net::URLFetcher instead?

Done.

[akalin, 2012-05-23 04:36:04]

TBRing OWNERS

[jam, 2012-05-23 05:27:30]

content lgtm (other than content/common/net which is already reviewed)