Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1306)

Issue 10459021: DEADCODE in #if'ed code. (Closed)

Created:
8 years, 6 months ago by Sheridan Rawlins
Modified:
8 years, 6 months ago
Reviewers:
jeanluc1, Evan Stade
CC:
chromium-reviews
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/browser/ui/gtk/first_run_dialog.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Sheridan Rawlins
Coverity fix.
8 years, 6 months ago (2012-05-30 01:08:18 UTC) #1
jeanluc1
lgtm
8 years, 6 months ago (2012-05-30 01:13:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/10459021/1
8 years, 6 months ago (2012-05-30 01:18:52 UTC) #3
commit-bot: I haz the power
Presubmit check for 10459021-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 6 months ago (2012-05-30 01:19:18 UTC) #4
Sheridan Rawlins
Evan, can you take a look?
8 years, 6 months ago (2012-05-30 01:29:19 UTC) #5
Evan Stade
lgtm
8 years, 6 months ago (2012-05-30 01:45:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/10459021/1
8 years, 6 months ago (2012-05-30 01:54:24 UTC) #7
commit-bot: I haz the power
8 years, 6 months ago (2012-05-30 07:43:58 UTC) #8
Change committed as 139479

Powered by Google App Engine
This is Rietveld 408576698