Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Issue 10540091: Rename gfx::Monitor to gfx::Display (Closed)

Created:
8 years, 6 months ago by tfarina
Modified:
8 years, 6 months ago
Reviewers:
oshima
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, dhollowa+watch_chromium.org, dcheng, stevenjb+watch_chromium.org, derat+watch_chromium.org, ben+watch_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, Andrei, jennb, jochen+watch-content_chromium.org, jonathan.backer, penghuang+watch_chromium.org, jianli, oshima+watch_chromium.org, piman+watch_chromium.org, Ian Vollick, Dmitry Titov, James Su
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+512 lines, -776 lines) Patch
M ash/dip_unittest.cc View 1 2 3 4 2 chunks +11 lines, -11 lines 0 comments Download
M ash/monitor/monitor_controller.h View 3 chunks +8 lines, -8 lines 0 comments Download
M ash/monitor/monitor_controller.cc View 3 chunks +16 lines, -16 lines 0 comments Download
M ash/monitor/multi_monitor_manager.h View 3 chunks +9 lines, -9 lines 0 comments Download
M ash/monitor/multi_monitor_manager.cc View 1 2 3 8 chunks +81 lines, -80 lines 0 comments Download
M ash/monitor/multi_monitor_manager_unittest.cc View 5 chunks +21 lines, -22 lines 0 comments Download
M ash/screen_ash.h View 2 chunks +4 lines, -4 lines 0 comments Download
M ash/screen_ash.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ash/shell.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M ash/shell.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/test/ash_test_base.cc View 1 2 3 4 2 chunks +6 lines, -6 lines 0 comments Download
M ash/touch/touch_observer_hud.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M ash/wm/shelf_layout_manager_unittest.cc View 1 2 8 chunks +28 lines, -28 lines 0 comments Download
M ash/wm/window_util.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/panels/display_settings_provider.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/internet_options_handler2.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/dip_util.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/aura.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/aura/desktop/desktop_screen_win.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/aura/desktop/desktop_screen_win.cc View 4 chunks +15 lines, -15 lines 0 comments Download
M ui/aura/desktop/desktop_screen_x11.cc View 3 chunks +10 lines, -10 lines 0 comments Download
A + ui/aura/display_observer.h View 1 chunk +9 lines, -9 lines 0 comments Download
A + ui/aura/display_observer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/aura/env.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/monitor_change_observer_x11.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/aura/monitor_change_observer_x11.cc View 1 2 7 chunks +12 lines, -13 lines 0 comments Download
M ui/aura/monitor_manager.h View 4 chunks +20 lines, -21 lines 0 comments Download
M ui/aura/monitor_manager.cc View 3 chunks +21 lines, -23 lines 0 comments Download
D ui/aura/monitor_observer.h View 1 chunk +0 lines, -35 lines 0 comments Download
D ui/aura/monitor_observer.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M ui/aura/root_window.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/single_monitor_manager.h View 3 chunks +7 lines, -7 lines 0 comments Download
M ui/aura/single_monitor_manager.cc View 4 chunks +22 lines, -22 lines 0 comments Download
M ui/aura/test/test_screen.h View 1 chunk +4 lines, -4 lines 0 comments Download
M ui/aura/test/test_screen.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M ui/base/x/events_x.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M ui/compositor/dip_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/compositor/layer.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ui/gfx/display.h View 4 chunks +23 lines, -23 lines 0 comments Download
A + ui/gfx/display.cc View 5 chunks +15 lines, -15 lines 0 comments Download
A ui/gfx/display_unittest.cc View 1 chunk +49 lines, -0 lines 0 comments Download
D ui/gfx/monitor.h View 1 chunk +0 lines, -100 lines 0 comments Download
D ui/gfx/monitor.cc View 1 chunk +0 lines, -111 lines 0 comments Download
D ui/gfx/monitor_unittest.cc View 1 chunk +0 lines, -49 lines 0 comments Download
M ui/gfx/screen.h View 2 chunks +8 lines, -8 lines 2 comments Download
M ui/gfx/screen_android.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ui/gfx/screen_aura.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M ui/gfx/screen_gtk.cc View 3 chunks +12 lines, -12 lines 0 comments Download
M ui/gfx/screen_impl.h View 2 chunks +4 lines, -4 lines 0 comments Download
M ui/gfx/screen_mac.mm View 1 4 chunks +15 lines, -15 lines 0 comments Download
M ui/gfx/screen_win.cc View 1 3 chunks +17 lines, -17 lines 0 comments Download
M ui/ui.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/ui_unittests.gypi View 2 chunks +1 line, -1 line 0 comments Download
M ui/views/widget/native_widget_aura.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
tfarina
8 years, 6 months ago (2012-06-11 00:44:15 UTC) #1
tfarina
ping??
8 years, 6 months ago (2012-06-11 23:27:07 UTC) #2
oshima
http://codereview.chromium.org/10540091/diff/14002/ui/gfx/screen.h File ui/gfx/screen.h (right): http://codereview.chromium.org/10540091/diff/14002/ui/gfx/screen.h#newcode43 ui/gfx/screen.h:43: static int GetNumMonitors(); GetNumDisplays http://codereview.chromium.org/10540091/diff/14002/ui/gfx/screen.h#newcode46 ui/gfx/screen.h:46: static gfx::Display GetMonitorNearestWindow(gfx::NativeView ...
8 years, 6 months ago (2012-06-12 00:48:01 UTC) #3
tfarina
On 2012/06/12 00:48:01, oshima wrote: > http://codereview.chromium.org/10540091/diff/14002/ui/gfx/screen.h > File ui/gfx/screen.h (right): > > http://codereview.chromium.org/10540091/diff/14002/ui/gfx/screen.h#newcode43 > ...
8 years, 6 months ago (2012-06-12 00:53:49 UTC) #4
oshima
8 years, 6 months ago (2012-06-12 01:03:34 UTC) #5
Don't you have to change the file that uses this API anyway?
If you want to do that in separate CL, that's fine though.

LGTM.

Powered by Google App Engine
This is Rietveld 408576698