Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10664037: Moved ExtensionMenuManager and ExtensionMenuItem into extensions namespace (Closed)

Created:
8 years, 6 months ago by Devlin
Modified:
8 years, 5 months ago
Reviewers:
miket_OOO
CC:
chromium-reviews, Avi (use Gerrit), mihaip-chromium-reviews_chromium.org, creis+watch_chromium.org, brettw-cc_chromium.org, Aaron Boodman, ajwong+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Moved ExtensionMenuManager and ExtensionMenuItem into extensions namespace; rename them to MenuManager and MenuItem. BUG=134711, 117261 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=145550

Patch Set 1 : #

Patch Set 2 : Merged with latest master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+471 lines, -2308 lines) Patch
M chrome/browser/extensions/api/context_menu/context_menu_api.h View 2 chunks +10 lines, -11 lines 0 comments Download
M chrome/browser/extensions/api/context_menu/context_menu_api.cc View 18 chunks +49 lines, -54 lines 0 comments Download
M chrome/browser/extensions/extension_context_menu_browsertest.cc View 8 chunks +14 lines, -13 lines 0 comments Download
D chrome/browser/extensions/extension_menu_manager.h View 1 chunk +0 lines, -358 lines 0 comments Download
D chrome/browser/extensions/extension_menu_manager.cc View 1 chunk +0 lines, -833 lines 0 comments Download
D chrome/browser/extensions/extension_menu_manager_unittest.cc View 1 chunk +0 lines, -629 lines 0 comments Download
M chrome/browser/extensions/extension_prefs.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_prefs.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_service.h View 1 4 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/extensions/menu_manager.h View 10 chunks +51 lines, -53 lines 0 comments Download
A + chrome/browser/extensions/menu_manager.cc View 40 chunks +128 lines, -136 lines 0 comments Download
A + chrome/browser/extensions/menu_manager_unittest.cc View 22 chunks +95 lines, -96 lines 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu.h View 6 chunks +10 lines, -11 lines 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu.cc View 16 chunks +48 lines, -48 lines 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu_unittest.cc View 16 chunks +60 lines, -58 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 2 chunks +2 lines, -2 lines 0 comments Download
chrome/chrome_tests.gypi View 1 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Devlin
Simple refactor; please review when time allows.
8 years, 5 months ago (2012-07-03 21:06:09 UTC) #1
miket_OOO
On 2012/07/03 21:06:09, D Cronin wrote: > Simple refactor; please review when time allows. Swell! ...
8 years, 5 months ago (2012-07-03 22:05:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/10664037/4030
8 years, 5 months ago (2012-07-05 18:10:20 UTC) #3
commit-bot: I haz the power
8 years, 5 months ago (2012-07-05 19:13:13 UTC) #4 
Change committed as 145550

Powered by Google App Engine
This is Rietveld 408576698