Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1077)

Issue 10882043: Revert 153291 - Fixes crash introduced @ 153047 (you can hit crash by maximizing a (Closed)

Created:
8 years, 4 months ago by sky
Modified:
8 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, Ian Vollick, piman+watch_chromium.org, jonathan.backer, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Revert 153291 - Fixes crash introduced @ 153047 (you can hit crash by maximizing a window). The cross fade code deletes the layer when the animation finishes. The newly added code was accessing members after the animation finished and the animator was deleted, resulting in the crash. Since I'm sure this will come up more in the future I've restructured the code to allow for deletion when calling out like this. The cross fade test exercises this code path now, but I'll see about a more focused tests shortly. BUG=129033 TEST=covered by tests. [email protected] Review URL: https://chromiumcodereview.appspot.com/10874064 [email protected] Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=153312

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -49 lines) Patch
M ash/wm/window_animations.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ash/wm/window_animations.cc View 3 chunks +12 lines, -1 line 0 comments Download
M ash/wm/window_animations_unittest.cc View 4 chunks +6 lines, -18 lines 0 comments Download
M ui/compositor/layer_animation_observer.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/compositor/layer_animation_observer.cc View 2 chunks +2 lines, -11 lines 0 comments Download
M ui/compositor/layer_animator.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/compositor/layer_animator.cc View 3 chunks +2 lines, -11 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
sky
8 years, 4 months ago (2012-08-24 22:09:24 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698