Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 10933105: Switch WebContentsUserData to be a friended base. (Closed)

Created:
8 years, 3 months ago by Avi (use Gerrit)
Modified:
8 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, Avi (use Gerrit), mihaip-chromium-reviews_chromium.org, creis+watch_chromium.org, marja+watch_chromium.org, Aaron Boodman, ajwong+watch_chromium.org
Visibility:
Public.

Description

Switch WebContentsUserData to be a friended base. BUG=107201 TEST=no visible change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156988

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -10 lines) Patch
M chrome/browser/extensions/tab_helper.h View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/sessions/session_tab_helper.h View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/web_contents_user_data.h View 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/web_contents_user_data_unittest.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M chrome/browser/ui/metro_pin_tab_helper.h View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Avi (use Gerrit)
Scott, you were right and I was wrong. Please take a look.
8 years, 3 months ago (2012-09-14 21:11:09 UTC) #1
sky
LGTM
8 years, 3 months ago (2012-09-14 23:05:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/10933105/1
8 years, 3 months ago (2012-09-14 23:13:54 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build. Your ...
8 years, 3 months ago (2012-09-15 01:04:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/10933105/1
8 years, 3 months ago (2012-09-15 01:06:20 UTC) #5
commit-bot: I haz the power
8 years, 3 months ago (2012-09-15 05:08:20 UTC) #6
Change committed as 156988

Powered by Google App Engine
This is Rietveld 408576698