Speculative fix for crash in the bug.

Speculative fix for crash in the bug.

BUG=149683
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157404

[oshima, 2012-09-18 01:23:48]

LGTM

https://codereview.chromium.org/10933136/diff/1/chrome/browser/ui/views/tab_c...
File
chrome/browser/ui/views/tab_contents/chrome_web_contents_view_delegate_views.cc
(right):

https://codereview.chromium.org/10933136/diff/1/chrome/browser/ui/views/tab_c...
chrome/browser/ui/views/tab_contents/chrome_web_contents_view_delegate_views.cc:142:
aura::RootWindow* root_window = web_contents_window->GetRootWindow();
I think you're getting NULL root window here (which make GetScreenPosition
return NULL).

[varunjain, 2012-09-18 01:27:59]

+sky for OWNERS

[sky, 2012-09-18 03:55:48]

https://codereview.chromium.org/10933136/diff/1/chrome/browser/ui/views/tab_c...
File
chrome/browser/ui/views/tab_contents/chrome_web_contents_view_delegate_views.cc
(right):

https://codereview.chromium.org/10933136/diff/1/chrome/browser/ui/views/tab_c...
chrome/browser/ui/views/tab_contents/chrome_web_contents_view_delegate_views.cc:142:
aura::RootWindow* root_window = web_contents_window->GetRootWindow();
On 2012/09/18 01:23:48, oshima wrote:
> I think you're getting NULL root window here (which make GetScreenPosition
> return NULL).

This is certainly possible as there are times when there is no parent.

[sky, 2012-09-18 16:23:17]

LGTM

[commit-bot: I haz the power, 2012-09-18 16:23:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/10933136/1

[commit-bot: I haz the power, 2012-09-18 19:35:21]

Change committed as 157404