Check that the user is signed in and the app has oauth2 section before recording an aouth2 grant.

Check that the user is signed in and the app has oauth2 section before recording an aouth2 grant.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161643

[Mihai Parparita -not on Chrome, 2012-10-11 21:27:47]

LGTM

Can you also then put back the boolean that I changed in r160978 (and remove the
TODO)?

[Munjal (Google), 2012-10-11 21:39:51]

Added back boolean and removed TODO.

[commit-bot: I haz the power, 2012-10-12 17:31:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/11066125/4001

[commit-bot: I haz the power, 2012-10-12 19:42:40]

Change committed as 161643

[Evan Stade, 2012-10-16 01:21:26]

lgtm

http://codereview.chromium.org/11066125/diff/4001/chrome/browser/extensions/p...
File chrome/browser/extensions/permissions_updater.cc (right):

http://codereview.chromium.org/11066125/diff/4001/chrome/browser/extensions/p...
chrome/browser/extensions/permissions_updater.cc:149: if (token_service &&
token_service->HasOAuthLoginToken()) {
no curlies :(

[Mihai Parparita -not on Chrome, 2012-10-16 04:08:44]

On Monday, October 15, 2012, wrote:
>
> chrome/browser/extensions/**permissions_updater.cc:149: if (token_service
> && token_service->**HasOAuthLoginToken()) {
> no curlies :(


The style guide says they're OK (
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Condit...)
and the Chromium style additions don't mention them.

Mihai

[Evan Stade, 2012-10-16 04:33:21]

> The style guide says they're OK (
>
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Condit...)
> and the Chromium style additions don't mention them.
> 
> Mihai

"Either is fine, but be consistent."

http://codereview.chromium.org/11066125/diff/4001/chrome/browser/extensions/p...
File chrome/browser/extensions/permissions_updater.cc (right):

http://codereview.chromium.org/11066125/diff/4001/chrome/browser/extensions/p...
chrome/browser/extensions/permissions_updater.cc:138: extension->location() !=
Extension::INTERNAL)
^

http://codereview.chromium.org/11066125/diff/4001/chrome/browser/extensions/p...
chrome/browser/extensions/permissions_updater.cc:169: if (!profile_ ||
!profile_->GetExtensionEventRouter())
^

http://codereview.chromium.org/11066125/diff/4001/chrome/browser/extensions/p...
chrome/browser/extensions/permissions_updater.cc:184: if (!changed ||
changed->IsEmpty())
^

http://codereview.chromium.org/11066125/diff/4001/chrome/browser/extensions/p...
chrome/browser/extensions/permissions_updater.cc:212: if
(profile_->IsSameProfile(profile))
^