Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(883)

Issue 11343038: Introduce IBusPanelService with empty implementation (Closed)

Created:
8 years, 1 month ago by Seigo Nonaka
Modified:
8 years, 1 month ago
Reviewers:
satorux1
CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

Introduce IBusPanelService with empty implementation. This patch set introduce only empty implementation for IBusPanelService. The actual implementation will be done with http://codereview.chromium.org/11342040/. BUG=158264 TEST=ran chromeos_unittests, unit_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=165914

Patch Set 1 : #

Total comments: 4

Patch Set 2 : Address comments #

Total comments: 2

Patch Set 3 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+304 lines, -18 lines) Patch
M chrome/browser/chromeos/input_method/input_method_engine_ibus.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/input_method_engine_ibus.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chromeos/chromeos.gyp View 2 chunks +4 lines, -0 lines 0 comments Download
M chromeos/dbus/ibus/ibus_constants.h View 2 chunks +24 lines, -0 lines 0 comments Download
M chromeos/dbus/ibus/ibus_engine_service.h View 3 chunks +2 lines, -9 lines 0 comments Download
M chromeos/dbus/ibus/ibus_engine_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/ibus/ibus_engine_service_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A chromeos/dbus/ibus/ibus_panel_service.h View 1 2 1 chunk +106 lines, -0 lines 0 comments Download
A chromeos/dbus/ibus/ibus_panel_service.cc View 1 chunk +93 lines, -0 lines 0 comments Download
A chromeos/dbus/ibus/mock_ibus_panel_service.h View 1 chunk +31 lines, -0 lines 0 comments Download
A chromeos/dbus/ibus/mock_ibus_panel_service.cc View 1 chunk +35 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Seigo Nonaka
8 years, 1 month ago (2012-10-30 12:23:27 UTC) #1
satorux1
http://codereview.chromium.org/11343038/diff/3001/chromeos/dbus/ibus/ibus_panel_service.h File chromeos/dbus/ibus/ibus_panel_service.h (right): http://codereview.chromium.org/11343038/diff/3001/chromeos/dbus/ibus/ibus_panel_service.h#newcode43 chromeos/dbus/ibus/ibus_panel_service.h:43: // Called when the IME updates the auxiliary text. ...
8 years, 1 month ago (2012-11-01 04:21:23 UTC) #2
Seigo Nonaka
http://codereview.chromium.org/11343038/diff/3001/chromeos/dbus/ibus/ibus_panel_service.h File chromeos/dbus/ibus/ibus_panel_service.h (right): http://codereview.chromium.org/11343038/diff/3001/chromeos/dbus/ibus/ibus_panel_service.h#newcode43 chromeos/dbus/ibus/ibus_panel_service.h:43: // Called when the IME updates the auxiliary text. ...
8 years, 1 month ago (2012-11-01 04:56:44 UTC) #3
satorux1
LGTM http://codereview.chromium.org/11343038/diff/8002/chromeos/dbus/ibus/ibus_panel_service.h File chromeos/dbus/ibus/ibus_panel_service.h (right): http://codereview.chromium.org/11343038/diff/8002/chromeos/dbus/ibus/ibus_panel_service.h#newcode43 chromeos/dbus/ibus/ibus_panel_service.h:43: // Called when the IME updates the auxiliary ...
8 years, 1 month ago (2012-11-05 04:36:57 UTC) #4
Seigo Nonaka
Thank you for your review. Submitting... http://codereview.chromium.org/11343038/diff/8002/chromeos/dbus/ibus/ibus_panel_service.h File chromeos/dbus/ibus/ibus_panel_service.h (right): http://codereview.chromium.org/11343038/diff/8002/chromeos/dbus/ibus/ibus_panel_service.h#newcode43 chromeos/dbus/ibus/ibus_panel_service.h:43: // Called when ...
8 years, 1 month ago (2012-11-05 05:02:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/11343038/6015
8 years, 1 month ago (2012-11-05 05:25:06 UTC) #6
commit-bot: I haz the power
Retried try job too often for step(s) browser_tests
8 years, 1 month ago (2012-11-05 06:59:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/11343038/6015
8 years, 1 month ago (2012-11-05 07:01:30 UTC) #8
commit-bot: I haz the power
8 years, 1 month ago (2012-11-05 09:47:45 UTC) #9
Change committed as 165914

Powered by Google App Engine
This is Rietveld 408576698