Issue 11441004: Restore previous null checks to ChromeContentBrowserClient.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11441004: Restore previous null checks to ChromeContentBrowserClient. (Closed)

Created:
8 years ago by Charlie Reis

Modified:
8 years ago

Reviewers:
Miranda Callahan, sky

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Restore previous null checks to ChromeContentBrowserClient. BUG=164223 TEST=Start Chrome with --site-per-process or --enable-strict-site-isolation Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171294

Patch Set 1 #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -4 lines)			Patch
	M	chrome/browser/chrome_content_browser_client.cc	View		4 chunks	+4 lines, -4 lines	0 comments	Download
	M	chrome/browser/chrome_content_browser_client_browsertest.cc	View		3 chunks	+19 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Miranda Callahan

On 2012/12/05 01:36:47, creis wrote: > Miranda, can you take a look? Thanks! LGTM -- ...

8 years ago (2012-12-05 13:46:13 UTC) #2

Charlie Reis

Scott, can you give an OWNERS review? (Looks like chrome_content_browser_client.cc doesn't usually need it, but ...

8 years ago (2012-12-05 16:41:50 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/11441004/1

8 years ago (2012-12-05 18:16:40 UTC) #5

Message was sent while issue was closed.

Change committed as 171294

Expand Messages | Collapse Messages