Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 11519047: Kill unnecessary HasSadTab() function. (Closed)

Created:
8 years ago by tfarina
Modified:
8 years ago
Reviewers:
sky
CC:
chromium-reviews
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : DCHECK_EQ #

Total comments: 2

Patch Set 3 : no get() ;) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -28 lines) Patch
M chrome/browser/ui/sad_tab_helper.h View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/sad_tab_helper.cc View 1 2 3 chunks +14 lines, -24 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tfarina
Hi Scott, could you review this to me? Thanks,
8 years ago (2012-12-12 23:54:26 UTC) #1
sky
https://codereview.chromium.org/11519047/diff/2001/chrome/browser/ui/sad_tab_helper.cc File chrome/browser/ui/sad_tab_helper.cc (right): https://codereview.chromium.org/11519047/diff/2001/chrome/browser/ui/sad_tab_helper.cc#newcode40 chrome/browser/ui/sad_tab_helper.cc:40: if (sad_tab_.get()) I believe you don't need the get() ...
8 years ago (2012-12-13 00:52:38 UTC) #2
tfarina
https://codereview.chromium.org/11519047/diff/2001/chrome/browser/ui/sad_tab_helper.cc File chrome/browser/ui/sad_tab_helper.cc (right): https://codereview.chromium.org/11519047/diff/2001/chrome/browser/ui/sad_tab_helper.cc#newcode40 chrome/browser/ui/sad_tab_helper.cc:40: if (sad_tab_.get()) On 2012/12/13 00:52:38, sky wrote: > I ...
8 years ago (2012-12-13 00:58:16 UTC) #3
sky
LGTM
8 years ago (2012-12-13 17:23:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/11519047/8001
8 years ago (2012-12-13 17:27:41 UTC) #5
commit-bot: I haz the power
8 years ago (2012-12-13 19:15:33 UTC) #6
Message was sent while issue was closed.
Change committed as 172913

Powered by Google App Engine
This is Rietveld 408576698