Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 11691010: Support multiple displays in EventGenerator (Closed)

Created:
7 years, 11 months ago by oshima
Modified:
7 years, 11 months ago
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Support multiple displays in EventGenerator - Introduces EventGeneratorDelegates interface that abstracts coordinates - Added AshEventGeneratorDelegates that uses screen coordinates in ash environment. - Updates several ash tests to use new EventGenerator I'll convert other tests in separate CL. BUG=139024 TEST=covered by tests. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176392

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+346 lines, -103 lines) Patch
M ash/extended_desktop_unittest.cc View 1 11 chunks +110 lines, -40 lines 6 comments Download
M ash/test/ash_test_base.h View 3 chunks +13 lines, -2 lines 0 comments Download
M ash/test/ash_test_base.cc View 1 5 chunks +40 lines, -1 line 0 comments Download
M ash/wm/activation_controller_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/aura/test/event_generator.h View 1 3 chunks +54 lines, -6 lines 0 comments Download
M ui/aura/test/event_generator.cc View 1 12 chunks +127 lines, -53 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
oshima
7 years, 11 months ago (2013-01-09 01:37:29 UTC) #1
Ben Goodger (Google)
lgtm https://codereview.chromium.org/11691010/diff/35009/ash/extended_desktop_unittest.cc File ash/extended_desktop_unittest.cc (right): https://codereview.chromium.org/11691010/diff/35009/ash/extended_desktop_unittest.cc#newcode90 ash/extended_desktop_unittest.cc:90: explicit EventLocationRecordingEventHandler() { not explicit https://codereview.chromium.org/11691010/diff/35009/ash/extended_desktop_unittest.cc#newcode112 ash/extended_desktop_unittest.cc:112: void ...
7 years, 11 months ago (2013-01-09 17:21:52 UTC) #2
oshima
trybot failure turns out to be a real bug in aura code. I'll fix the ...
7 years, 11 months ago (2013-01-10 06:13:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/11691010/35009
7 years, 11 months ago (2013-01-11 16:28:40 UTC) #4
commit-bot: I haz the power
7 years, 11 months ago (2013-01-11 18:35:45 UTC) #5
Message was sent while issue was closed.
Change committed as 176392

Powered by Google App Engine
This is Rietveld 408576698