Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 12262028: change some string types in wallet code (Closed)

Created:
7 years, 10 months ago by Evan Stade
Modified:
7 years, 10 months ago
Reviewers:
ahutter, Ilya Sherman
CC:
chromium-reviews, Raman Kakilate, benquan, dhollowa+watch_chromium.org, ahutter, browser-components-watch_chromium.org, dbeam+watch-autofill_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Albert Bodenhamer, Ilya Sherman
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : sync #

Patch Set 3 : fix stringprintf breakage #

Patch Set 4 : base:: #

Patch Set 5 : more fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+234 lines, -223 lines) Patch
M chrome/browser/autofill/wallet/full_wallet_unittest.cc View 2 chunks +21 lines, -18 lines 0 comments Download
M chrome/browser/autofill/wallet/instrument.h View 1 4 chunks +9 lines, -8 lines 0 comments Download
M chrome/browser/autofill/wallet/instrument.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/autofill/wallet/instrument_unittest.cc View 1 13 chunks +28 lines, -27 lines 0 comments Download
M chrome/browser/autofill/wallet/wallet_address.h View 1 3 chunks +28 lines, -28 lines 0 comments Download
M chrome/browser/autofill/wallet/wallet_address.cc View 1 6 chunks +28 lines, -29 lines 0 comments Download
M chrome/browser/autofill/wallet/wallet_address_unittest.cc View 1 2 3 4 4 chunks +40 lines, -39 lines 0 comments Download
M chrome/browser/autofill/wallet/wallet_client.cc View 1 2 3 3 chunks +8 lines, -6 lines 0 comments Download
M chrome/browser/autofill/wallet/wallet_items.h View 1 4 chunks +10 lines, -9 lines 0 comments Download
M chrome/browser/autofill/wallet/wallet_items.cc View 1 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/autofill/wallet/wallet_items_unittest.cc View 1 4 chunks +30 lines, -29 lines 0 comments Download
M chrome/browser/autofill/wallet/wallet_test_util.cc View 1 2 chunks +20 lines, -18 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/autofill/data_model_wrapper.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Evan Stade
strings that are used for display should be string16. I tried to only convert strings ...
7 years, 10 months ago (2013-02-13 23:34:59 UTC) #1
Ilya Sherman
lgtm
7 years, 10 months ago (2013-02-14 00:03:13 UTC) #2
ahutter
lgtm https://codereview.chromium.org/12262028/diff/1/chrome/browser/autofill/wallet/instrument.h File chrome/browser/autofill/wallet/instrument.h (right): https://codereview.chromium.org/12262028/diff/1/chrome/browser/autofill/wallet/instrument.h#newcode67 chrome/browser/autofill/wallet/instrument.h:67: std::string primary_account_number_; This is user input. https://codereview.chromium.org/12262028/diff/1/chrome/browser/autofill/wallet/instrument.h#newcode70 chrome/browser/autofill/wallet/instrument.h:70: ...
7 years, 10 months ago (2013-02-14 22:17:01 UTC) #3
ahutter
lgtm
7 years, 10 months ago (2013-02-14 22:17:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/12262028/6001
7 years, 10 months ago (2013-02-19 17:53:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/12262028/18001
7 years, 10 months ago (2013-02-20 04:14:33 UTC) #6
commit-bot: I haz the power
7 years, 10 months ago (2013-02-20 08:11:20 UTC) #7
Message was sent while issue was closed.
Change committed as 183429

Powered by Google App Engine
This is Rietveld 408576698