Crop images from custom themes before storing them into the theme pack

Crop images from custom themes before storing them into the theme pack. 

BUG=176857
Test=None
R=erg
TBR=sky (For ui/linux_ui/linux_ui.h)

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192595

[pkotwicz, 2013-04-03 02:16:13]

After some thought, I decided that we should wait before breaking existing
themes / asking theme authors to make changes. I do not think that we have made
significant enough improvements wrt to themes yet to validate either.

I simplified https://codereview.chromium.org/13212010/ so that we only crop
frame images on platforms which have no border to the left and the right of the
web contents.
The CL still crops super large IDR_THEME_TOOLBAR on all platforms.

[Elliot Glaysher, 2013-04-03 17:23:35]

https://codereview.chromium.org/13497002/diff/1008/chrome/browser/themes/brow...
File chrome/browser/themes/browser_theme_pack.cc (right):

https://codereview.chromium.org/13497002/diff/1008/chrome/browser/themes/brow...
chrome/browser/themes/browser_theme_pack.cc:562:
pack->CreateImages(&pack->images_on_file_thread_);
I think that somethings gone a little screwy here. It looks like
|images_on_file_thread_| and |images_on_ui_thread_| are now identical. And
you're creating all the images twice?

[pkotwicz, 2013-04-03 20:27:22]

https://codereview.chromium.org/13497002/diff/1008/chrome/browser/themes/brow...
File chrome/browser/themes/browser_theme_pack.cc (right):

https://codereview.chromium.org/13497002/diff/1008/chrome/browser/themes/brow...
chrome/browser/themes/browser_theme_pack.cc:562:
pack->CreateImages(&pack->images_on_file_thread_);
You are right that this is suboptimal. I will take a pass to fix this better
than I did in this patch set in another CL. In particular, I will do the fix
before we launch hidpi Windows.
We were doing lazy loading so it was not quite as bad as creating the images
twice sequentially (but still pretty bad).

[Elliot Glaysher, 2013-04-03 20:38:30]

lgtm

[commit-bot: I haz the power, 2013-04-04 18:50:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/13497002/38001

[commit-bot: I haz the power, 2013-04-04 18:50:51]

Presubmit check for 13497002-38001 failed and returned exit status 1.

INFO:root:Found 7 file(s).

Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/PRESUBMIT.py
Running
/b/commit-queue/workdir/chromium/chrome/browser/ui/libgtk2ui/PRESUBMIT.py

** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
    ui/linux_ui/linux_ui.h

Presubmit checks took 4.2s to calculate.

[commit-bot: I haz the power, 2013-04-04 20:01:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/13497002/38001

[commit-bot: I haz the power, 2013-04-04 20:02:33]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_rel_de...

[commit-bot: I haz the power, 2013-04-05 14:51:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/13497002/53001

[commit-bot: I haz the power, 2013-04-05 17:52:15]

Change committed as 192595