Issue 14283013: Reland https://chromiumcodereview.appspot.com/14286004 which was reverted fue

Issue 14283013: Reland https://chromiumcodereview.appspot.com/14286004 which was reverted fue (Closed)

Created:
7 years, 8 months ago by varunjain

Modified:
7 years, 8 months ago

Reviewers:
Avi (use Gerrit), sky

CC:
chromium-reviews, nkostylev+watch_chromium.org, ben+watch_chromium.org, tfarina, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, oshima+watch_chromium.org, James Su, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Reland https://chromiumcodereview.appspot.com/14286004 which was reverted fue to linux_chromeos_asan build break. The cause of the break has since been fixed in https://codereview.chromium.org/14113034/ There are no additional changes from the original CL. BUG=115237, 168162 [email protected],[email protected] Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=196927

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+84 lines, -27 lines)			Patch
M	chrome/browser/about_flags.cc	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/login/chrome_restart_request.cc	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	content/browser/renderer_host/render_process_host_impl.cc	View	3 chunks	+4 lines, -2 lines	0 comments	Download
M	content/browser/web_contents/touch_editable_impl_aura.cc	View	3 chunks	+2 lines, -6 lines	0 comments	Download
M	content/renderer/render_view_impl.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	ui/base/ui_base_switches.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	ui/base/ui_base_switches.cc	View	2 chunks	+7 lines, -0 lines	0 comments	Download
A	ui/base/ui_base_switches_util.h	View	1 chunk	+18 lines, -0 lines	0 comments	Download
A	ui/base/ui_base_switches_util.cc	View	1 chunk	+32 lines, -0 lines	0 comments	Download
M	ui/ui.gyp	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	ui/views/controls/textfield/native_textfield_views.cc	View	3 chunks	+2 lines, -4 lines	0 comments	Download
M	ui/views/touchui/touch_selection_controller_impl.cc	View	2 chunks	+2 lines, -6 lines	0 comments	Download
M	ui/views/view.cc	View	3 chunks	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/14283013/1

7 years, 8 months ago (2013-04-26 23:18:02 UTC) #2

commit-bot: I haz the power

Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=107784

7 years, 8 months ago (2013-04-27 00:13:43 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/14283013/1

7 years, 8 months ago (2013-04-27 00:19:14 UTC) #4

Message was sent while issue was closed.

stampity stamp lgtm

Expand Messages | Collapse Messages