Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 15132004: Ignore ManagedState changes to existing state. (Closed)

Created:
7 years, 7 months ago by stevenjb
Modified:
7 years, 7 months ago
CC:
chromium-reviews, gauravsh+watch_chromium.org, gspencer+watch_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

Ignore ManagedState changes to existing state. Changing state to an existing state is a no-op that produces event log noise and extra callbacks. BUG=239652 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=200229

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : Include header comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -13 lines) Patch
M chromeos/network/managed_state.h View 1 2 3 chunks +6 lines, -4 lines 0 comments Download
M chromeos/network/managed_state.cc View 1 1 chunk +24 lines, -9 lines 0 comments Download
M chromeos/network/network_state_handler_unittest.cc View 1 2 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
stevenjb
Please review as soon as convenient.
7 years, 7 months ago (2013-05-13 16:38:21 UTC) #1
pneubeck (no reviews)
On 2013/05/13 16:38:21, stevenjb (chromium) wrote: > Please review as soon as convenient. the changes ...
7 years, 7 months ago (2013-05-14 16:31:51 UTC) #2
stevenjb
On 2013/05/14 16:31:51, pneubeck wrote: > On 2013/05/13 16:38:21, stevenjb (chromium) wrote: > > Please ...
7 years, 7 months ago (2013-05-14 17:18:25 UTC) #3
pneubeck (no reviews)
lgtm
7 years, 7 months ago (2013-05-14 20:34:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/15132004/8003
7 years, 7 months ago (2013-05-14 20:58:12 UTC) #5
commit-bot: I haz the power
7 years, 7 months ago (2013-05-15 10:01:28 UTC) #6
Message was sent while issue was closed.
Change committed as 200229

Powered by Google App Engine
This is Rietveld 408576698