drive: Create cache directories in DriveIntegrationService

drive: Create cache directories in DriveIntegrationService

'meta' directory is hosting both DBs for FileCache and ResourceMetadata.
Since these DBs are going to be merged into one, this directory should be created outside FileCache to initialize
the shared unified DB.

Create directories in DriveIntegrationService.
Remove directory related code from FileCache.
Move directory name constants to file_system_util.h
Pass temporary directory path as an argument, instead of using GetCacheDirectory() from DownloadOperation.

BUG=234487
TEST=unit_tests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207160

[kinaba, 2013-06-18 04:08:51]

https://codereview.chromium.org/17236002/diff/4001/chrome/browser/chromeos/dr...
File chrome/browser/chromeos/drive/file_cache.cc (right):

https://codereview.chromium.org/17236002/diff/4001/chrome/browser/chromeos/dr...
chrome/browser/chromeos/drive/file_cache.cc:708:
cache_file_directory_.DirName().AppendASCII("persistent");
This is getting a little bit complex. Could you add a short comment on what's
going on this path calculation?
(Also, is it safe in tests?)

[hashimoto, 2013-06-18 08:58:41]

https://codereview.chromium.org/17236002/diff/4001/chrome/browser/chromeos/dr...
File chrome/browser/chromeos/drive/file_cache.cc (right):

https://codereview.chromium.org/17236002/diff/4001/chrome/browser/chromeos/dr...
chrome/browser/chromeos/drive/file_cache.cc:708:
cache_file_directory_.DirName().AppendASCII("persistent");
On 2013/06/18 04:08:51, kinaba wrote:
> This is getting a little bit complex. Could you add a short comment on what's
> going on this path calculation?
> (Also, is it safe in tests?)

Good catch, tests would be messed up if directories named "tmp" or "persistent"
is placed under /tmp.
Moved the function to file_system_util.cc and calling it from
DriveIntegrationService.

[kinaba, 2013-06-18 09:24:55]

lgtm. thanks!

[commit-bot: I haz the power, 2013-06-18 09:26:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/17236002/34001

[commit-bot: I haz the power, 2013-06-18 14:02:29]

Retried try job too often on win_rel for step(s) chrome_frame_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-06-19 02:31:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/17236002/34001

[commit-bot: I haz the power, 2013-06-19 03:43:15]

Change committed as 207160