Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 18125003: Use a direct include of time headers in chrome/browser/, part 3. (Closed)

Created:
7 years, 5 months ago by Avi (use Gerrit)
Modified:
7 years, 5 months ago
CC:
chromium-reviews, asanka, extensions-reviews_chromium.org, felt, nkostylev+watch_chromium.org, derat+watch_chromium.org, tommycli, benjhayden+dwatch_chromium.org, jam, joi+watch-content_chromium.org, Lei Zhang, darin-cc_chromium.org, oshima+watch_chromium.org, vandebo (ex-Chrome), chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, Greg Billock, davemoore+watch_chromium.org
Visibility:
Public.

Description

Use a direct include of time headers in chrome/browser/, part 3. BUG=254986 TEST=none [email protected] Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=209039

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -100 lines) Patch
M chrome/browser/chromeos/policy/auto_enrollment_client.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/device_status_collector.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/recommendation_restorer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/recommendation_restorer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/recommendation_restorer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/power/user_activity_notifier.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/power/video_activity_notifier.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/screensaver/screensaver_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/session_length_limiter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/settings/device_oauth2_token_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/settings/session_manager_operation.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/settings/system_settings_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/status/network_menu_icon.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/system/ash_system_tray_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/system/automatic_reboot_manager.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/system/statistics_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/ui/idle_logout_dialog_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/ui/idle_logout_dialog_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/upgrade_detector_chromeos.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/version_loader.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/component_updater/component_updater_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/diagnostics/diagnostics_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/chrome_download_manager_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_item_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_query.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_query_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_shelf.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_target_determiner.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/drive/drive_notification_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/drive/event_logger.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/enumerate_modules_model_win.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/enumerate_modules_model_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/activity_log/activity_actions.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/activity_log/activity_database.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/activity_log/activity_database.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/activity_log/activity_database_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/activity_log/activity_log_policy.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/activity_log/activity_log_policy.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/alarms/alarm_manager.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/alarms/alarm_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/app_window/app_window_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/bookmarks/bookmarks_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/content_settings/content_settings_store.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/cookies/cookies_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/declarative/declarative_rule.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/declarative/rules_registry_with_cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/declarative_content/content_rules_registry.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_action_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/dial/dial_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/dial/dial_device_data.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/dial/dial_registry.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/dial/dial_registry.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/dial/dial_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/dial/dial_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/history/history_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/idle/idle_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/media_galleries_private/gallery_watch_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/messaging/native_message_process_host_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/notifications/notifications_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/record/record_api.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/rtc_private/rtc_private_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/system_info_cpu/cpu_info_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/system_info_storage/storage_info_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/system_info_storage/system_info_storage_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/web_navigation/web_navigation_api_helpers.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_api.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_api_helpers.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_api_helpers.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_api_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_time_tracker.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/web_socket_proxy_private/web_socket_proxy_private_api.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/convert_web_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/convert_web_app_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/crx_installer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_info_map.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_pref_value_map.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_prefs.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_process_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_process_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extensions_quota_service.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/external_registry_loader_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/sandboxed_unpacker.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/token_cache/token_cache_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/token_cache/token_cache_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/updater/extension_downloader.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/updater/extension_downloader_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/updater/extension_updater.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/updater/request_queue.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/18125003/1
7 years, 5 months ago (2013-06-27 18:53:22 UTC) #1
Lei Zhang
lgtm, I really wish we did this 3 years ago when there were a lot ...
7 years, 5 months ago (2013-06-27 19:40:49 UTC) #2
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=170141
7 years, 5 months ago (2013-06-27 21:00:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/18125003/1
7 years, 5 months ago (2013-06-27 21:11:27 UTC) #4
commit-bot: I haz the power
7 years, 5 months ago (2013-06-28 00:27:58 UTC) #5
Message was sent while issue was closed. 
Change committed as 209039

Powered by Google App Engine
This is Rietveld 408576698