Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Issue 18367002: Add the android_aosp trybot to PRESUBMIT.py (Closed)

Created:
7 years, 5 months ago by mkosiba (inactive)
Modified:
7 years, 5 months ago
Reviewers:
iannucci, M-A Ruel
CC:
chromium-reviews
Visibility:
Public.

Description

Add the android_aosp trybot to PRESUBMIT.py This adds the android_aosp trybot to the preferred trybot set. BUG=None NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=209667

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M PRESUBMIT.py View 1 2 3 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
mkosiba (inactive)
PTAL.
7 years, 5 months ago (2013-07-01 18:18:13 UTC) #1
mkosiba (inactive)
@iannucci - would love to be able to use PRESUBMIT.py GetPreferredTrySlaves to determine whether a ...
7 years, 5 months ago (2013-07-01 18:19:05 UTC) #2
iannucci
On 2013/07/01 18:19:05, mkosiba wrote: > @iannucci - would love to be able to use ...
7 years, 5 months ago (2013-07-01 18:31:45 UTC) #3
iannucci
This lgtm. We'll need a separate CL to add it to the CQ though.
7 years, 5 months ago (2013-07-02 08:41:33 UTC) #4
iannucci
spelling nit https://codereview.chromium.org/18367002/diff/4001/PRESUBMIT.py File PRESUBMIT.py (right): https://codereview.chromium.org/18367002/diff/4001/PRESUBMIT.py#newcode1042 PRESUBMIT.py:1042: # The AOSP bot doesn't build the ...
7 years, 5 months ago (2013-07-02 08:41:43 UTC) #5
mkosiba (inactive)
https://codereview.chromium.org/18367002/diff/4001/PRESUBMIT.py File PRESUBMIT.py (right): https://codereview.chromium.org/18367002/diff/4001/PRESUBMIT.py#newcode1042 PRESUBMIT.py:1042: # The AOSP bot doesn't build the chrome/ layer, ...
7 years, 5 months ago (2013-07-02 09:13:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/18367002/12001
7 years, 5 months ago (2013-07-02 09:16:31 UTC) #7
commit-bot: I haz the power
Change committed as 209667
7 years, 5 months ago (2013-07-02 10:51:01 UTC) #8
M-A Ruel
7 years, 5 months ago (2013-07-08 18:54:31 UTC) #9
Message was sent while issue was closed.
On 2013/07/01 18:31:45, iannucci wrote:
> On 2013/07/01 18:19:05, mkosiba wrote:
> > @iannucci - would love to be able to use PRESUBMIT.py GetPreferredTrySlaves
to
> > determine whether a change does or does not go to the AOSP bot. How hard
would
> > that be? :)
> 
> Given the current design of the CQ, I'd say that would be in the 'hard'
category
> (though M-A may know otherwise?)

"Hard but doable"
https://code.google.com/p/chromium/issues/detail?id=108484

Powered by Google App Engine
This is Rietveld 408576698