Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 19805006: [Android] Release overscroll glow when the scroll gesture ends (Closed)

Created:
7 years, 5 months ago by jdduke (slow)
Modified:
7 years, 5 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[Android] Release overscroll glow when the scroll gesture ends This matches stock Android browser overscroll behavior by releasing the effect immediately when the user ends the scroll gesture (e.g., lifts their finger). BUG=135975 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213831

Patch Set 1 #

Patch Set 2 : Comments and improved naming #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -20 lines) Patch
M content/browser/android/overscroll_glow.h View 1 3 chunks +7 lines, -3 lines 0 comments Download
M content/browser/android/overscroll_glow.cc View 1 4 chunks +12 lines, -16 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
jdduke (slow)
PTAL. aelias@: content/browser/renderer_host/render_widget_host_view_android.cc joth@:content/browser/renderer_host/render_widget_host_view_android.{h,cc}
7 years, 5 months ago (2013-07-24 19:13:18 UTC) #1
jdduke (slow)
On 2013/07/24 19:13:18, jdduke wrote: > PTAL. > > aelias@: content/browser/renderer_host/render_widget_host_view_android.cc > joth@:content/browser/renderer_host/render_widget_host_view_android.{h,cc} Oops. joth@: ...
7 years, 5 months ago (2013-07-24 19:13:46 UTC) #2
joth
overscroll_glow.* lgtm with the changes discussed
7 years, 5 months ago (2013-07-24 19:18:30 UTC) #3
aelias_OOO_until_Jul13
lgtm
7 years, 5 months ago (2013-07-25 20:13:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/19805006/21001
7 years, 5 months ago (2013-07-25 20:50:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/19805006/21001
7 years, 5 months ago (2013-07-26 01:22:48 UTC) #6
commit-bot: I haz the power
7 years, 5 months ago (2013-07-26 10:55:01 UTC) #7
Message was sent while issue was closed.
Change committed as 213831

Powered by Google App Engine
This is Rietveld 408576698