Issue 22872009: Disallow use of content::TestBrowserContext from //chrome/browser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22872009: Disallow use of content::TestBrowserContext from //chrome/browser. (Closed)

Created:
7 years, 4 months ago by Jói

Modified:
7 years, 4 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Disallow use of content::TestBrowserContext from //chrome/browser. Remove the single such use that I found. Full rationale in chromium-dev thread at http://goo.gl/QQG5wo. Short story is that this can lead to an invalid cast (to Profile) in some of the commonly-used test harnesses under //chrome/browser, and within //chrome/browser a TestingProfile should be used instead. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=218006

Patch Set 1 #

Patch Set 2 : Rename variable. #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -4 lines)			Patch
	M	chrome/browser/DEPS	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	M	chrome/browser/extensions/event_listener_map_unittest.cc	View	1	3 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/22872009/2001

7 years, 4 months ago (2013-08-16 09:09:27 UTC) #3

Message was sent while issue was closed.

Change committed as 218006

Expand Messages | Collapse Messages