Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 9363007: Propogate status setting for profiler to track parents (Closed)

Created:
8 years, 10 months ago by jar (doing other things)
Modified:
8 years, 10 months ago
Reviewers:
jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, brettw-cc_chromium.org
Visibility:
Public.

Description

Propogate status setting for profiler to track parents [Reland: https://src.chromium.org/viewvc/chrome?view=rev&revision=120789 with minor change to avoid race on status change.] This allows child processes to track ancestry, and report it to the browser process. Parent tracking is only turned on based on an environment variable. r=rtenneti Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=121491

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -64 lines) Patch
M base/profiler/tracked_time_unittest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M base/tracked_objects.h View 1 chunk +6 lines, -4 lines 0 comments Download
M base/tracked_objects.cc View 4 chunks +17 lines, -14 lines 0 comments Download
M base/tracked_objects_unittest.cc View 17 chunks +31 lines, -18 lines 0 comments Download
M chrome/browser/chrome_browser_main.cc View 1 2 3 1 chunk +8 lines, -2 lines 0 comments Download
M content/browser/profiler_controller_impl.h View 4 chunks +6 lines, -3 lines 0 comments Download
M content/browser/profiler_controller_impl.cc View 3 chunks +8 lines, -6 lines 0 comments Download
M content/browser/profiler_message_filter.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 3 4 1 chunk +3 lines, -2 lines 0 comments Download
M content/common/child_process_messages.h View 3 chunks +5 lines, -2 lines 0 comments Download
M content/common/child_thread.h View 3 chunks +3 lines, -2 lines 0 comments Download
M content/common/child_thread.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M content/public/browser/profiler_controller.h View 1 2 3 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jar (doing other things)
Raman: This is what you reviewed, with the status change pushed inside the if statement ...
8 years, 10 months ago (2012-02-08 01:00:48 UTC) #1
jam
8 years, 10 months ago (2012-02-10 19:25:13 UTC) #2
content lgtm

Powered by Google App Engine
This is Rietveld 408576698