Issue 9566001: Hide MHTMLGenerationManager from chrome.

Issue 9566001: Hide MHTMLGenerationManager from chrome. (Closed)

Created:
8 years, 9 months ago by jam

Modified:
8 years, 9 months ago

Reviewers:
Jói

CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, ajwong+watch_chromium.org, jam, mihaip+watch_chromium.org, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, rdsmith+dwatch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Hide MHTMLGenerationManager from chrome. BUG=98716 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124430

Patch Set 1 #

Total comments: 2

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+44 lines, -65 lines)			Patch
M	chrome/browser/DEPS	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/browser_process.h	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/browser_process_impl.h	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/browser_process_impl.cc	View	2 chunks	+0 lines, -8 lines	0 comments	Download
M	chrome/browser/chrome_content_browser_client.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/chrome_content_browser_client.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/extensions/extension_page_capture_api.cc	View	2 chunks	+3 lines, -6 lines	0 comments	Download
M	chrome/test/base/testing_browser_process.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/test/base/testing_browser_process.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	content/browser/download/mhtml_generation_browsertest.cc	View	2 chunks	+2 lines, -6 lines	0 comments	Download
M	content/browser/download/mhtml_generation_manager.h	View	4 chunks	+8 lines, -8 lines	0 comments	Download
M	content/browser/download/mhtml_generation_manager.cc	View	6 chunks	+13 lines, -5 lines	0 comments	Download
M	content/browser/mock_content_browser_client.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/browser/mock_content_browser_client.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	content/browser/renderer_host/render_process_host_impl.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	content/browser/tab_contents/tab_contents.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	content/browser/tab_contents/tab_contents.cc	View	2 chunks	+7 lines, -0 lines	0 comments	Download
M	content/public/browser/content_browser_client.h	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	content/public/browser/web_contents.h	View	2 chunks	+7 lines, -0 lines	2 comments	Download
M	content/shell/shell_content_browser_client.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/shell/shell_content_browser_client.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jói

LGTM, just a nit http://codereview.chromium.org/9566001/diff/1/content/public/browser/web_contents.h File content/public/browser/web_contents.h (right): http://codereview.chromium.org/9566001/diff/1/content/public/browser/web_contents.h#newcode273 content/public/browser/web_contents.h:273: // Generate a MHTML representation ...

8 years, 9 months ago (2012-03-01 10:42:13 UTC) #2

jam

8 years, 9 months ago (2012-03-01 18:10:17 UTC) #3

http://codereview.chromium.org/9566001/diff/1/content/public/browser/web_cont...
File content/public/browser/web_contents.h (right):

http://codereview.chromium.org/9566001/diff/1/content/public/browser/web_cont...
content/public/browser/web_contents.h:273: // Generate a MHTML representation of
the current page in the given file.
On 2012/03/01 10:42:13, Jói wrote:
> Generate a MHTML -> Generate an MHTML

Done.

Expand Messages | Collapse Messages