Main
| Legend: | Passed | Failed | Running | Exception |
[RPP] Support loading compressed enhanced traces
Bug: 432043263
Change-Id: Id5bacaa55e6b32d06b8eb4e8a19e1a4321bbb6f9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6761382
Commit-Queue: Paul Irish <[email protected]>
Reviewed-by: Paul Irish <[email protected]>
Commit-Queue: Connor Clark <[email protected]>
Auto-Submit: Connor Clark <[email protected]>
Document HostedMode, canDock, and remoteBase
Change-Id: Ib56ab92284144e376b51e1d7aaf64ff2bdcbfa82
Bug: none
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6765826
Auto-Submit: Paul Irish <[email protected]>
Commit-Queue: Paul Irish <[email protected]>
Reviewed-by: Danil Somsikov <[email protected]>
[e2e] Fix flaky memory panel test
Use our helper and an extra drainTask to stabilize the test.
No-Tree-Checks: True
Bug: none
Change-Id: I7f9c9f2846350fc14f9dcb5c8ed9b6e976e005c0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6765967
Commit-Queue: Nikolay Vitkov <[email protected]>
Reviewed-by: Jack Franklin <[email protected]>
[cleanup] Remove unnecessary typecasting
This types are now properly inferred by TypeScript.
Bug: none
Change-Id: Ic7ccd8221b2eb70d5a23d7cdd6e1b1f393ace8b7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6765131
Commit-Queue: Nikolay Vitkov <[email protected]>
Auto-Submit: Nikolay Vitkov <[email protected]>
Reviewed-by: Jack Franklin <[email protected]>
Commit-Queue: Jack Franklin <[email protected]>
[cleanup] Remove requirement for types
The types from package.json say version v4 when we are using v13.
Because v13 comes with the types out of the box we don't need this.
The package will be remove as part of updating all packages CL.
Bug: none
Change-Id: I1cc3a8b57d60ef6ac8830a07dc1720b26b3bf576
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6764816
Reviewed-by: Jack Franklin <[email protected]>
Commit-Queue: Jack Franklin <[email protected]>
Auto-Submit: Nikolay Vitkov <[email protected]>
Update DevTools DEPS (trusted)
Rolling buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/c2f4137..bf449a9
Roll created at https://cr-buildbucket.appspot.com/build/8709098352451171041
Bug: none
Change-Id: Ic9c6274deb0caefe9e33c4ba9dcc531476ad67f9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6764528
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
[e2e] Increase timeout for Memory tests
Before moving the test to e2e non hosted the test had timeout
of 100_000, I lowered it to 20_000 but it seems like the bots need
more so bumping them a little bit before we investigate.
Bug: none
Change-Id: I94a35397a9a5b7de48f15bae87e6089759682c7a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6765762
Commit-Queue: Jack Franklin <[email protected]>
Commit-Queue: Nikolay Vitkov <[email protected]>
Reviewed-by: Jack Franklin <[email protected]>
Pre-fix for packages bump
When updating the packages in package.json some new issue were found.
I fix them in this CL to split them up.
Bug: none.
Change-Id: I8339de288a2816679867fcfe4791e33ce92abc44
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6764815
Commit-Queue: Nikolay Vitkov <[email protected]>
Reviewed-by: Danil Somsikov <[email protected]>
Auto-Submit: Nikolay Vitkov <[email protected]>
Commit-Queue: Danil Somsikov <[email protected]>
UI Eng Vision: migrate Timeline.RelatedInsightChips
Fixed: 407941548
Change-Id: Ifad450e2fd55694481948f59706929a2c425e485
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6760831
Commit-Queue: Jack Franklin <[email protected]>
Reviewed-by: Danil Somsikov <[email protected]>
[UIEngineering] Update `inject-checkbox-styles` for `widgetScoped` calls
We'll wrap styles inside `widgetScoped` calls in `<style>` tags. We'll
need to account for them in the `inject-checkbox-styles` rule.
Bug: 431945418
Change-Id: I0c625cc5300c0d05c43d28a5ce5b407455a582ee
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6765324
Auto-Submit: Ergün Erdoğmuş <[email protected]>
Commit-Queue: Ergün Erdoğmuş <[email protected]>
Reviewed-by: Nikolay Vitkov <[email protected]>
Reviewed-by: Danil Somsikov <[email protected]>
Use compressed network requests format to stringifying multiple network requests
Since the compressed format also requires to provide the format descirprion to the LLM, do not use it for instances when only a single network request is sent. In that case, use the verbose json-like format that has a field name for each value.
Bug: 427939495
Change-Id: I20133bcdcac4c14f0e7bd12d6cb639cfef349385
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6732758
Auto-Submit: Alina Varkki <[email protected]>
Reviewed-by: Jack Franklin <[email protected]>
Commit-Queue: Alina Varkki <[email protected]>
[sdk] Use library ScopeInfoBuilder in SourceMapScopesInfo tests
The current tests encode and decode the scopes info because we don't
have an easy way to build the scope data structures. The tests don't
really check that, they verify *how* scopes info is utilized.
The codec library has a builder, so we can use that instead.
Note: The CL was generated in parts by gemini-cli.
Drive-by: Change the constructor signature to take a
`Codec.ScopeInfo` instead of 2 separate arrays.
[email protected]
Bug: 368222773
Change-Id: I07e3355f44d8446d0be8ce3238e5bad9df2b6b15
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6765322
Commit-Queue: Simon Zünd <[email protected]>
Reviewed-by: Philip Pfaffe <[email protected]>
Roll puppeteer-core
This roll requires a manual review. See http://go/reviewed-rolls for guidance.
In case of failures or errors, reach out to someone from config/owner/RECORDER_OWNERS.
Roll created at https://cr-buildbucket.appspot.com/build/8709132326351594113
[email protected]
Bug: none
Change-Id: I8aac1e37baf4ea3d1abe7e36790dc6a50610faa1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6760538
Reviewed-by: Simon Zünd <[email protected]>
Reviewed-by: Benedikt Meurer <[email protected]>
Commit-Queue: Jack Franklin <[email protected]>
Reviewed-by: Danil Somsikov <[email protected]>
Reviewed-by: Jack Franklin <[email protected]>
Add code for creating request and parsing codeComplete response
Bug: 430199612
Change-Id: I1cd0d1125f5e62cdc8a281c004d974e4390cc349
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6733145
Reviewed-by: Ergün Erdoğmuş <[email protected]>
Commit-Queue: Samiya Caur <[email protected]>
[AnimationTimeline] Render toolbar view declaratively
My plan for the migration is to:
* Move all the rendering responsibilities of AnimationTimeline to be
in partial view functions in their respective containers.
* Then, combine all of them into one big view function and finish
migration.
Bug: 407748396
Change-Id: I9719cf30bbe2169db3cce0cee9615b8684fb26a3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6757110
Reviewed-by: Danil Somsikov <[email protected]>
Auto-Submit: Ergün Erdoğmuş <[email protected]>
Commit-Queue: Ergün Erdoğmuş <[email protected]>
Add VE logging to floating buttons
This CL adds visual logging to the floating action buttons in the
Elements, Network, and Sources panels.
A `jslog-context` attribute was added to the `FloatingButton`
component to allow specifying a logging context. This will allow
tracking of clicks on these buttons for analytics.
The visual logging debugging documentation was also updated to
reflect the latest state of the debugging UI.
Fixed: 429381292
Change-Id: I30a3227d99fbd26aa19962a2b56be21cb949ed10
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6728038
Reviewed-by: Danil Somsikov <[email protected]>
Auto-Submit: Natallia Harshunova <[email protected]>
Reviewed-by: Ergün Erdoğmuş <[email protected]>
Commit-Queue: Danil Somsikov <[email protected]>
[network] Allow NetworkRequetNodes to be gc'ed when the log is cleared
The network panel currently associates each NetworkRequest with it's
UI data grid node via a WeakMap. But since the ResourceTreeModel never
frees up NetworkRequests, we keep every <tr> of the Network panel alive
indefinitely.
This CL fixes at least the DOM element leak: When the view is reset,
we also reset the WeakMap. While we keep the NetworkRequests around
for now, at least we no longer keep detached DOM nodes around
indefinitely.
Drive-by: Make the module global a class member.
[email protected]
Bug: 390559089
Change-Id: I014ec2c56bab20f6c48c85cb205476860ea5c829
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6759714
Auto-Submit: Simon Zünd <[email protected]>
Reviewed-by: Philip Pfaffe <[email protected]>
Commit-Queue: Simon Zünd <[email protected]>
[deps] Update source-map-scopes-codec to version 0.5.0
The update contains support for sub-range binding expressions and
support for decoding index source maps.
Bug: 368222773
Change-Id: I6543ac9a8080b19e204516728f1a30272d36fee7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6764507
Auto-Submit: Simon Zünd <[email protected]>
Reviewed-by: Benedikt Meurer <[email protected]>
Commit-Queue: Benedikt Meurer <[email protected]>
Commit-Queue: Simon Zünd <[email protected]>
Roll browser-protocol
This roll requires a manual review. See http://go/reviewed-rolls for guidance.
In case of failures or errors, reach out to someone from config/owner/COMMON_OWNERS.
Roll created at https://cr-buildbucket.appspot.com/build/8709132326351594113
[email protected]
Bug: none
Change-Id: I4ce4d503ff0a3097005c8142ad944c1181c02ae2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6760519
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Reviewed-by: Philip Pfaffe <[email protected]>
Commit-Queue: Philip Pfaffe <[email protected]>
[styles] Evaluate sibling-index(), sibling-count()
Fixed: 417128001
Change-Id: I2c8891bb8b423251e65683a243394fceac048c47
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6759937
Reviewed-by: Eric Leese <[email protected]>
Commit-Queue: Philip Pfaffe <[email protected]>
Auto-Submit: Philip Pfaffe <[email protected]>
Move Memory test to E2E non hosted
Fixed: 416405547
Change-Id: I7d84ed6a64f4c3a2d2c1bed1c96d1b7134f61bb1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6759939
Auto-Submit: Nikolay Vitkov <[email protected]>
Reviewed-by: Simon Zünd <[email protected]>
Commit-Queue: Simon Zünd <[email protected]>
Update DevTools DEPS (trusted)
Rolling buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/bb0dbc3..c2f4137
Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/8532fbc..5e6b392
Roll created at https://cr-buildbucket.appspot.com/build/8709132326351594113
Bug: none
Change-Id: Ib51052c1c7459238cea49f8ab20215fda444a3c2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6760537
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Define common gzip helper methods
Also we no longer need to define the interfaces as they're now in
@types/node/stream/web.d.ts
Bug:432043263
Change-Id: I268a0b377457e71cb6528a436ef1369572853d2d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6761794
Commit-Queue: Paul Irish <[email protected]>
Reviewed-by: Connor Clark <[email protected]>
Auto-Submit: Paul Irish <[email protected]>
[DeepLink] Rename filter to shouldHandleOpenResource
Bug:427430112
Change-Id: I0d1fbf067daaf69fd5e31074a27698531973a0a1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6758891
Reviewed-by: Finnur Thorarinsson <[email protected]>
Auto-Submit: Paul Irish <[email protected]>
Commit-Queue: Finnur Thorarinsson <[email protected]>
[RPP] Let Legacy / Duplicated insights work w/o nav
This was an oversight that prevented these insights from working for
insight sets w/o a navigation.
Bug: none
Change-Id: I0c707673f64198398c2eb48f32f75af9cd995362
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6758794
Auto-Submit: Connor Clark <[email protected]>
Reviewed-by: Paul Irish <[email protected]>
Commit-Queue: Connor Clark <[email protected]>
Commit-Queue: Paul Irish <[email protected]>
Remove footer from ExploreView, move learn about AI link to a new place.
Remove Explore View's footer as part of larger cleanup of AI Assistance
panel.
Preserve the "Learn about AI in DevTools" link by moving it up under the
header.
Fixed: 416414550
Change-Id: I26e9d0fe28209b9ada6749f75a152ec4cdc6ef1b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6759715
Commit-Queue: Piotr Paulski <[email protected]>
Reviewed-by: Nikolay Vitkov <[email protected]>
Update DevTools DEPS (trusted)
Rolling third_party/inspector_protocol: https://chromium.googlesource.com/deps/inspector_protocol/+log/6d1ae0f..bdc11c1
Roll created at https://cr-buildbucket.appspot.com/build/8709188949839476209
Bug: none
Change-Id: I4eaf38287c4905f718e73c07c1fc6ce20f95ad92
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6760650
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Add support for preamble features in client_version
Bug: 432049117
Change-Id: I0d788bc1578e2f5d6458f6553fde3c66c765af0c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6732853
Commit-Queue: Alex Rudenko <[email protected]>
Reviewed-by: Wolfgang Beyer <[email protected]>
[cleanup] Remove implicit any from no-imperative-dom-api rule
This provides types for the rules so it's easier to append more thing
in the future and provides better tyo safety.
Bug: none
Change-Id: Ic85bcb02a555db0632050c8a5b69493a07b58c26
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6757117
Reviewed-by: Danil Somsikov <[email protected]>
Auto-Submit: Nikolay Vitkov <[email protected]>
Commit-Queue: Nikolay Vitkov <[email protected]>
[cleanup] Use proper type and not type casting
We should prefer typing the property to typecasting the value that
will be inferred.
Bug: none
Change-Id: Id2309b740a27c4e35e151bc38f57a2eed0d2bac9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6759810
Reviewed-by: Danil Somsikov <[email protected]>
Auto-Submit: Nikolay Vitkov <[email protected]>
Commit-Queue: Danil Somsikov <[email protected]>
Commit-Queue: Nikolay Vitkov <[email protected]>
Add comment to Brand type
This add a explanation why we don's use a Symbol to hide this from
IDEs and improve build checks.
Bug: none
Change-Id: Icb9ed0df194a46e09bcf01d3c066e35de10438f1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6757118
Auto-Submit: Nikolay Vitkov <[email protected]>
Reviewed-by: Jack Franklin <[email protected]>
Commit-Queue: Jack Franklin <[email protected]>
Roll browser-protocol
This roll requires a manual review. See http://go/reviewed-rolls for guidance.
In case of failures or errors, reach out to someone from config/owner/COMMON_OWNERS.
Roll created at https://cr-buildbucket.appspot.com/build/8709222922247142497
[email protected]
Bug: none
Change-Id: I82c20dc8b0c6807230975d9c82dd9e75f20610d4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6758872
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Jack Franklin <[email protected]>
Reviewed-by: Jack Franklin <[email protected]>
[UIEngineering] Add an ESLint rule checking for `widgetScoped` usage in view functions
Bug: 431945418
Change-Id: I9d6f24b90d2dd3a1bd00325a7fade155e8fc55be
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6757116
Auto-Submit: Ergün Erdoğmuş <[email protected]>
Reviewed-by: Danil Somsikov <[email protected]>
Commit-Queue: Danil Somsikov <[email protected]>
Speculative loads: replace icon
Previously, we were using the same icon as background fetch. Now we have our own icon.
Screenshot: https://drive.google.com/file/d/1fKDszeffKv_7oSF9uDBL98I3_bIKbmj3/view?usp=sharing
Fixed: 40278201
Change-Id: I6a6b1d76f287424fef71505d12a6186bb7d5ee8a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6683218
Reviewed-by: Peter Müller <[email protected]>
Commit-Queue: Domenic Denicola <[email protected]>
Update DevTools DEPS (trusted)
Rolling buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/839dbfe..bb0dbc3
Rolling third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/fa0292b..8532fbc
Rolling third_party/siso: git_revision:f96f46a8e4cf30c097110903d4b71516ef976fb6..git_revision:dcd000e47f19677c7a5e02550abafa9eadbd4923
Roll created at https://cr-buildbucket.appspot.com/build/8709222922247142497
Bug: none
Change-Id: I12a3dbf42fb1081bb6970728aaaa228f1cd5d22a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6758871
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
[RPP] Hide irrelevant toolbar buttons for standalone usages
For enhanced traces and for embedded standalone usages of the
Performance panel (such as trace.cafe), hide all the toolbar actions
that are irrelevant in the context where recording a new trace is not
possible.
Bug: 432043754
Change-Id: Ieb7f50e74a1e45e9304550544834328d7d179c02
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6544870
Commit-Queue: Paul Irish <[email protected]>
Auto-Submit: Connor Clark <[email protected]>
Reviewed-by: Paul Irish <[email protected]>
[AiAssistance] Fix wrongly assigning to `.jslogContext` instead of `jslog`
Bug: none
Change-Id: I0566bc050e2585486245340ea954ad0abf2e479a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6732392
Reviewed-by: Nikolay Vitkov <[email protected]>
Commit-Queue: Nikolay Vitkov <[email protected]>
Auto-Submit: Ergün Erdoğmuş <[email protected]>
Commit-Queue: Ergün Erdoğmuş <[email protected]>
[e2e] Migrate the shortcut settings test
Migrates the test and helpers to the new test runner.
Fixed: 416404619
Change-Id: I9803586659e6ec7ffe143f5b0648a671e63149d6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6732391
Auto-Submit: Nikolay Vitkov <[email protected]>
Reviewed-by: Alex Rudenko <[email protected]>
Commit-Queue: Alex Rudenko <[email protected]>
[cleanup] Remove unnecessary type casting
This type are unnecessary as they can be inferred by TypeScript It also
replaces type casting `as` with ! when we want to show that the value is
present.
Bug: none
Change-Id: I7889d92577b22a10f1d8b045a8f4ce28847770c5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6757113
Commit-Queue: Nikolay Vitkov <[email protected]>
Reviewed-by: Benedikt Meurer <[email protected]>
Auto-Submit: Nikolay Vitkov <[email protected]>
Add config for AI auto complete suggestions
Bug: 430199612
Change-Id: If2f6d280518ad306184362be87b7c41b79d1149a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6733144
Reviewed-by: Ergün Erdoğmuş <[email protected]>
Commit-Queue: Samiya Caur <[email protected]>
Test runner: add `--cpu-throttle=` CLI flag and remove STRESS env var
[email protected]
Bug: none
Change-Id: Ie881543734a4900244e12b19d834c52c8daa5026
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6757111
Commit-Queue: Jack Franklin <[email protected]>
Reviewed-by: Philip Pfaffe <[email protected]>
An adorner to force-open popovers
Show an adorner for popover elements. When clicked, the popover is
forced open and can only be closed by toggling the adorner again. In
particular, this will prevent closing the popover by the page via
javascript or events.
Fixed: 413580647
Change-Id: Ia1c9b727b48adaebd0e66fae0c4cac4cc5f827bf
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6488092
Commit-Queue: Philip Pfaffe <[email protected]>
Reviewed-by: Changhao Han <[email protected]>
Migrate test/e2e/throttling/cpu_calibration_test.ts
Fixed: 416405666
Change-Id: I6a8976b279bc87a0e8aea53ebf4fb8c134d5cf2a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6733267
Auto-Submit: Liviu Rau <[email protected]>
Commit-Queue: Alex Rudenko <[email protected]>
Reviewed-by: Alex Rudenko <[email protected]>
Add request, response and function call for CodeComplete
Bug: 430199612
Change-Id: Icd2482a00b38bd42103abe447be769070fbf009c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6723290
Commit-Queue: Samiya Caur <[email protected]>
Reviewed-by: Ergün Erdoğmuş <[email protected]>
Auto-Submit: Samiya Caur <[email protected]>
[UIEngineering] Add `Styling` section to documentation
Bug: 431945418
Change-Id: I53a79479b5064ed412a78edba6fa465a7f7d0599
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6757207
Reviewed-by: Danil Somsikov <[email protected]>
Commit-Queue: Danil Somsikov <[email protected]>
Auto-Submit: Ergün Erdoğmuş <[email protected]>
[UIEngineering] Add `widgetScoped` helper to scope styles to a widget's view
Bug: 431945418
Change-Id: I45b91e90c66e7364d19e2ad15625d17a4c8aa9e1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6733265
Reviewed-by: Danil Somsikov <[email protected]>
Commit-Queue: Ergün Erdoğmuş <[email protected]>
Roll puppeteer-core
This roll requires a manual review. See http://go/reviewed-rolls for guidance.
In case of failures or errors, reach out to someone from config/owner/RECORDER_OWNERS.
Roll created at https://cr-buildbucket.appspot.com/build/8709279547392662977
[email protected]
Bug: none
Change-Id: If00781ea22e406030ec28c8b473ca7152bcfe917
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6735228
Reviewed-by: Nikolay Vitkov <[email protected]>
Reviewed-by: Jack Franklin <[email protected]>
Commit-Queue: Jack Franklin <[email protected]>
Ask AI for Modern HTTP was accidentally removed
It was accidentally removed by https://crrev.com/c/6695989
[email protected]
Bug: none
Change-Id: I33e1a8f3841a6acf9e2f6cadd1c2032cd35ad44e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6734437
Auto-Submit: Alina Varkki <[email protected]>
Reviewed-by: Jack Franklin <[email protected]>
Commit-Queue: Jack Franklin <[email protected]>
[application] Fix DOM Storage item creation with empty values.
The refactoring in https://crrev.com/c/6249842 missed the `|| ''` on the
`value`, and CDP was choking on `undefined`.
Fixed: 414506467
Bug: 394287937
Change-Id: Ieb81d00272db4531e45cf6327167a03830521582
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6734248
Commit-Queue: Benedikt Meurer <[email protected]>
Commit-Queue: Yang Guo <[email protected]>
Reviewed-by: Yang Guo <[email protected]>
Auto-Submit: Benedikt Meurer <[email protected]>
Update DevTools DEPS (trusted)
Rolling buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/428390e..839dbfe
Roll created at https://cr-buildbucket.appspot.com/build/8709279547392662977
Bug: none
Change-Id: I274825983d96ea312e4565d03083f79cc1a0a43f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6735227
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>