Add support for default values of IPC_STRUCT_MEMBER.

Add support for default values of IPC_STRUCT_MEMBER.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132435

[jam, 2012-04-13 18:02:33]

I'll defer to Tom who wrote these macros.

[Tom Sepez, 2012-04-13 18:22:37]

LGTM.

https://chromiumcodereview.appspot.com/10067023/diff/1/ipc/ipc_message_macros.h
File ipc/ipc_message_macros.h (right):

https://chromiumcodereview.appspot.com/10067023/diff/1/ipc/ipc_message_macros...
ipc/ipc_message_macros.h:205: #define IPC_STRUCT_MEMBER(type, name, ...) type
name;
Nit: maybe a comment here that the elipsis represents optional constructor
default args.

[jbates, 2012-04-14 00:35:11]

https://chromiumcodereview.appspot.com/10067023/diff/1/ipc/ipc_message_macros.h
File ipc/ipc_message_macros.h (right):

https://chromiumcodereview.appspot.com/10067023/diff/1/ipc/ipc_message_macros...
ipc/ipc_message_macros.h:205: #define IPC_STRUCT_MEMBER(type, name, ...) type
name;
On 2012/04/13 18:22:37, Tom Sepez wrote:
> Nit: maybe a comment here that the elipsis represents optional constructor
> default args.

Done.

[commit-bot: I haz the power, 2012-04-14 00:36:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/10067023/4002

[commit-bot: I haz the power, 2012-04-14 00:58:05]

Try job failure for 10067023-4002 (retry) on linux_chromeos for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2012-04-14 01:01:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/10067023/4002

[commit-bot: I haz the power, 2012-04-14 02:47:27]

Try job failure for 10067023-4002 (retry) on mac_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2012-04-16 16:52:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/10067023/4002

[commit-bot: I haz the power, 2012-04-16 19:13:04]

Change committed as 132435