Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 10068036: RefCounted types should not have public destructors, chrome/browser/ part 5 (Closed)

Created:
8 years, 8 months ago by Ryan Sleevi
Modified:
8 years, 8 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip+watch_chromium.org
Visibility:
Public.

Description

RefCounted types should not have public destructors, chrome/browser/ part 5 BUG=123295 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133870

Patch Set 1 #

Patch Set 2 : Implementation file ordering #

Patch Set 3 : Win fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+345 lines, -266 lines) Patch
M chrome/browser/password_manager/mock_password_store.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/password_manager/mock_password_store.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/password_manager/password_manager.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/password_manager/password_store.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/password_manager/password_store_win.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/policy/configuration_policy_pref_store.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/policy/configuration_policy_pref_store.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/policy/device_management_service.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/policy/file_based_policy_loader.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/prefs/command_line_pref_store.h View 1 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/prefs/command_line_pref_store.cc View 1 2 chunks +13 lines, -13 lines 0 comments Download
M chrome/browser/prefs/command_line_pref_store_unittest.cc View 2 chunks +8 lines, -5 lines 0 comments Download
M chrome/browser/prefs/default_pref_store.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/prefs/default_pref_store.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/prefs/overlay_user_pref_store.h View 1 2 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/prefs/overlay_user_pref_store.cc View 1 3 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/prefs/testing_pref_store.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/prefs/testing_pref_store.cc View 1 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/prefs/value_map_pref_store.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/prefs/value_map_pref_store.cc View 1 3 chunks +16 lines, -16 lines 0 comments Download
M chrome/browser/printing/cloud_print/cloud_print_proxy_service.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/printing/cloud_print/virtual_driver_install_helper.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/printing/print_job_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/printing/print_preview_tab_controller.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/printing/print_preview_tab_controller.cc View 1 4 chunks +35 lines, -35 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 1 3 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/profiles/refcounted_profile_keyed_service.h View 3 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/safe_browsing/client_side_detection_host_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/download_protection_service_unittest.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/malware_details_cache.h View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/malware_details_cache.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/safe_browsing/malware_details_history.h View 1 3 chunks +18 lines, -16 lines 0 comments Download
M chrome/browser/safe_browsing/malware_details_history.cc View 1 3 chunks +21 lines, -22 lines 0 comments Download
M chrome/browser/safe_browsing/malware_details_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_service.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc View 1 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_test.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/speech/speech_input_extension_api.h View 1 2 chunks +25 lines, -10 lines 0 comments Download
M chrome/browser/speech/speech_input_extension_api.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/speech/speech_recognition_bubble_controller.h View 1 3 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/speech/speech_recognition_bubble_controller.cc View 1 5 chunks +64 lines, -64 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_message_filter.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/spellchecker/spellcheck_message_filter.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_message_filter_mac.h View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/spellchecker/spellcheck_message_filter_mac.cc View 1 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_message_filter_mac_browsertest.cc View 4 chunks +7 lines, -10 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Ryan Sleevi
thestig: chrome/browser/printing mnissler: chrome/browser/policy erg: chrome/browser/profiles
8 years, 8 months ago (2012-04-13 09:07:07 UTC) #1
Ryan Sleevi
And since 'git cl presubmit' forgot to mention OWNERS for the other directories shess: safe_browsing/ ...
8 years, 8 months ago (2012-04-13 09:10:21 UTC) #2
Mattias Nissler (ping if slow)
chrome/browser/prefs and chrome/browser/policy LGTM
8 years, 8 months ago (2012-04-13 09:17:12 UTC) #3
Satish
chrome/browser/speech LGTM
8 years, 8 months ago (2012-04-13 09:50:41 UTC) #4
Hironori Bono
LGTM for chrome/browser/spellchecker. Thanks for noticing it. Regards, Hironori Bono
8 years, 8 months ago (2012-04-13 10:00:24 UTC) #5
Scott Hess - ex-Googler
safe_browsing LGTM
8 years, 8 months ago (2012-04-13 13:46:25 UTC) #6
Elliot Glaysher
profiles lgtm
8 years, 8 months ago (2012-04-13 17:54:01 UTC) #7
Lei Zhang
printing LGTM
8 years, 8 months ago (2012-04-13 19:05:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/10068036/8001
8 years, 8 months ago (2012-04-25 04:23:15 UTC) #9
commit-bot: I haz the power
Try job failure for 10068036-8001 (retry) on win_rel for step "compile" (clobber build). It's a ...
8 years, 8 months ago (2012-04-25 05:30:45 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/10068036/15002
8 years, 8 months ago (2012-04-25 05:43:02 UTC) #11
commit-bot: I haz the power
8 years, 8 months ago (2012-04-25 07:01:09 UTC) #12
Change committed as 133870

Powered by Google App Engine
This is Rietveld 408576698