[ash] Add TYPE_DIALOG and its item's LauncherContextMenu

[ash] Add TYPE_DIALOG and its item's LauncherContextMenu

This is third CL for adding an item for dialog.
This cl adds new LauncherItemType, TYPE_DIALOG, and 
implements a context menu of item created by ShelfWindowWatcher.

[email protected]
BUG=121242
TEST=NONE

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243965

[simonhong, 2013-12-13 02:24:30]

Dear sky,
Please take a look.

[sky, 2013-12-16 21:09:44]

Can we share the context menu code used in the chrome side instead of
duplicating parts of it?

https://codereview.chromium.org/107163005/diff/1/ash/shelf/shelf_item_context...
File ash/shelf/shelf_item_context_menu.h (right):

https://codereview.chromium.org/107163005/diff/1/ash/shelf/shelf_item_context...
ash/shelf/shelf_item_context_menu.h:64: ash::Shell* shell_;
Why not use Shell::GetInstance() instead of caching this?

[simonhong, 2013-12-17 08:19:29]

Dear sky,
I implemented a ContextMenu by using existing LauncherContextMenu and add
TYPE_DIALOG.
Please check again and many thanks for review!

[simonhong, 2013-12-19 19:15:32]

kindly ping..

[sky, 2013-12-20 00:05:40]

I'm gone until the 6th. If you can't wait you'll need to get another reviewer.

On Thu, Dec 19, 2013 at 11:15 AM,  <[email protected]> wrote:
> kindly ping..
>
> https://codereview.chromium.org/107163005/

To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].

[simonhong, 2014-01-07 12:54:42]

kindly ping..

[sky, 2014-01-08 14:39:14]

https://codereview.chromium.org/107163005/diff/40001/ash/shelf/shelf_view.cc
File ash/shelf/shelf_view.cc (right):

https://codereview.chromium.org/107163005/diff/40001/ash/shelf/shelf_view.cc#...
ash/shelf/shelf_view.cc:1: // Copyright 2013 The Chromium Authors. All rights
reserved.
Don't change the year here.

https://codereview.chromium.org/107163005/diff/40001/chrome/browser/ui/ash/la...
File chrome/browser/ui/ash/launcher/launcher_context_menu.cc (right):

https://codereview.chromium.org/107163005/diff/40001/chrome/browser/ui/ash/la...
chrome/browser/ui/ash/launcher/launcher_context_menu.cc:275:
controller_->Close(item_.id);
Why can'
t controller_->Close(item_.id); do the right thing here? Meaning go through the
ShelfItemDelegate?

[simonhong, 2014-01-09 00:38:23]

Dear sky,
Please check my comment, again.
Many thanks for review.

https://codereview.chromium.org/107163005/diff/40001/ash/shelf/shelf_view.cc
File ash/shelf/shelf_view.cc (right):

https://codereview.chromium.org/107163005/diff/40001/ash/shelf/shelf_view.cc#...
ash/shelf/shelf_view.cc:1: // Copyright 2013 The Chromium Authors. All rights
reserved.
On 2014/01/08 14:39:14, sky wrote:
> Don't change the year here.

Done.

https://codereview.chromium.org/107163005/diff/40001/chrome/browser/ui/ash/la...
File chrome/browser/ui/ash/launcher/launcher_context_menu.cc (right):

https://codereview.chromium.org/107163005/diff/40001/chrome/browser/ui/ash/la...
chrome/browser/ui/ash/launcher/launcher_context_menu.cc:275:
controller_->Close(item_.id);
On 2014/01/08 14:39:14, sky wrote:
> Why can'
> t controller_->Close(item_.id); do the right thing here? Meaning go through
the
> ShelfItemDelegate?

Yes, TYPE_DIALOG is not managed by controller_.
I think using a ShelfItemDelegate interface for Close(), IsOpen() and etc is
better not through controller_.
How about this refactoring as a TODO?

[sky, 2014-01-09 15:57:27]

Ok, LGTM

[commit-bot: I haz the power, 2014-01-09 17:01:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/107163005/110001

[commit-bot: I haz the power, 2014-01-09 17:01:37]

Failed to apply patch for ash/shell/shell_delegate_impl.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file ash/shell/shell_delegate_impl.h
  Hunk #1 FAILED at 55.
  1 out of 1 hunk FAILED -- saving rejects to file
ash/shell/shell_delegate_impl.h.rej

Patch:       ash/shell/shell_delegate_impl.h
Index: ash/shell/shell_delegate_impl.h
diff --git a/ash/shell/shell_delegate_impl.h b/ash/shell/shell_delegate_impl.h
index
473c42c5dbc8664237716520ba3647c10ef9a40e..92c19815b48432e76119cca4f600f2b84107a1ef
100644
--- a/ash/shell/shell_delegate_impl.h
+++ b/ash/shell/shell_delegate_impl.h
@@ -55,7 +55,9 @@ class ShellDelegateImpl : public ash::ShellDelegate {
   virtual ash::MediaDelegate* CreateMediaDelegate() OVERRIDE;
   virtual aura::client::UserActionClient* CreateUserActionClient() OVERRIDE;
   virtual ui::MenuModel* CreateContextMenu(
-      aura::Window* root_window) OVERRIDE;
+      aura::Window* root_window,
+      ash::ShelfItemDelegate* item_delegate,
+      ash::LauncherItem* item) OVERRIDE;
   virtual RootWindowHostFactory* CreateRootWindowHostFactory() OVERRIDE;
   virtual base::string16 GetProductName() const OVERRIDE;

[commit-bot: I haz the power, 2014-01-09 17:52:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/107163005/180001

[commit-bot: I haz the power, 2014-01-09 20:26:00]

Change committed as 243965