Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 108043005: aura: Start updating aura to use EventProcessor for event dispatch. (Closed)

Created:
7 years ago by sadrul
Modified:
7 years ago
CC:
chromium-reviews, ben+aura_chromium.org, kalyank, tdanderson
Visibility:
Public.

Description

aura: Start updating aura to use EventProcessor for event dispatch. Notable changes in this CL: * A WindowTargeter implementation for finding the target Window for an event (currently unused), with only a most basic test. * Make RootWindow a ui::EventProcessor. * Make RootWindowHostX11 a ui::EventSource. Note that RootWindowHostX11 continues to dispatch events to the RootWindow using RootWindowHostDelegate interface. This CL prepares much of the machinery for switching to EventProcessor interface for event dispatch, but it is essentially a no-op for now. BUG=318879 [email protected] Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=239277

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+248 lines, -47 lines) Patch
M ui/aura/aura.gyp View 2 chunks +3 lines, -0 lines 0 comments Download
M ui/aura/root_window.h View 6 chunks +13 lines, -4 lines 0 comments Download
M ui/aura/root_window.cc View 14 chunks +44 lines, -23 lines 0 comments Download
M ui/aura/root_window_host_x11.h View 3 chunks +6 lines, -0 lines 0 comments Download
M ui/aura/root_window_host_x11.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/aura/root_window_host_x11_unittest.cc View 4 chunks +33 lines, -18 lines 0 comments Download
M ui/aura/window.h View 2 chunks +2 lines, -0 lines 0 comments Download
A ui/aura/window_targeter.h View 1 chunk +25 lines, -0 lines 0 comments Download
A ui/aura/window_targeter.cc View 1 chunk +59 lines, -0 lines 0 comments Download
A ui/aura/window_targeter_unittest.cc View 1 chunk +54 lines, -0 lines 0 comments Download
M ui/aura/window_tree_host_delegate.h View 2 chunks +3 lines, -0 lines 0 comments Download
M ui/events/event_source.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/event_source.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
sadrul
7 years ago (2013-12-06 12:22:22 UTC) #1
Ben Goodger (Google)
lgtm
7 years ago (2013-12-06 18:23:54 UTC) #2
sadrul
7 years ago (2013-12-06 23:55:55 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r239277 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698