beginnings of metro viewer process

Bunch of boilerplate to set up a process, ipc, etc.

Only hooked up in "aura_demo --viewer" right now, and doesn't actually accomplish anything other than opening a window yet.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=157367

[scottmg, 2012-08-23 18:10:31]

fyi. No idea if any of this is sensible until I figure out what's going on a bit
more.

[scottmg, 2012-08-27 22:59:16]

PTAL when you have a chance. Planning to add the host side connection next, and
then the actual real-work part where it passes some sort of a gpu buffer handle
to the viewer.

[Ben Goodger (Google), 2012-08-27 23:28:41]

Cool! LGTM.

[tfarina, 2012-08-28 00:54:22]

http://codereview.chromium.org/10872002/diff/10003/ui/ui.gyp
File ui/ui.gyp (right):

http://codereview.chromium.org/10872002/diff/10003/ui/ui.gyp#newcode775
ui/ui.gyp:775: 'target_name': 'viewer',
nonono, please, like ui/app_list, ui/views, and what not, provide a
ui/viewer/viewer.gyp.

[tfarina, 2012-08-28 00:55:36]

http://codereview.chromium.org/10872002/diff/10003/ui/viewer/viewer_main.cc
File ui/viewer/viewer_main.cc (right):

http://codereview.chromium.org/10872002/diff/10003/ui/viewer/viewer_main.cc#n...
ui/viewer/viewer_main.cc:18: // TODO(scottmg): Constant.
why don't you do this now? It shouldn't take too much time. If you can't, I can
fix this later ;)

[tfarina, 2012-08-28 01:14:15]

http://codereview.chromium.org/10872002/diff/10003/ui/viewer/viewer_ipc_server.h
File ui/viewer/viewer_ipc_server.h (right):

http://codereview.chromium.org/10872002/diff/10003/ui/viewer/viewer_ipc_serve...
ui/viewer/viewer_ipc_server.h:35: 
rm this extra blank line.

[tfarina, 2012-08-28 01:15:51]

http://codereview.chromium.org/10872002/diff/10003/ui/viewer/viewer_host_win.h
File ui/viewer/viewer_host_win.h (right):

http://codereview.chromium.org/10872002/diff/10003/ui/viewer/viewer_host_win....
ui/viewer/viewer_host_win.h:9: #include "ui/aura/root_window.h"
why can't you forward declare this?

http://codereview.chromium.org/10872002/diff/10003/ui/viewer/viewer_host_win....
ui/viewer/viewer_host_win.h:15: class ViewerHostWin {
can this be at least in ui namespace?

http://codereview.chromium.org/10872002/diff/10003/ui/viewer/viewer_host_win....
ui/viewer/viewer_host_win.h:18: virtual ~ViewerHostWin();
does this needs to be virtual?

http://codereview.chromium.org/10872002/diff/10003/ui/viewer/viewer_host_win....
ui/viewer/viewer_host_win.h:25: };
DISALLOW_COPY_AND_ASSIGN?

[tfarina, 2012-08-28 01:17:08]

http://codereview.chromium.org/10872002/diff/10003/ui/aura/demo/demo_main.cc
File ui/aura/demo/demo_main.cc (right):

http://codereview.chromium.org/10872002/diff/10003/ui/aura/demo/demo_main.cc#...
ui/aura/demo/demo_main.cc:181:
ResourceBundle::InitSharedInstanceWithLocale("en-US", NULL);
ui::ResourceBundle

[tfarina, 2012-08-28 01:19:45]

http://codereview.chromium.org/10872002/diff/10003/ui/viewer/viewer_process.cc
File ui/viewer/viewer_process.cc (right):

http://codereview.chromium.org/10872002/diff/10003/ui/viewer/viewer_process.c...
ui/viewer/viewer_process.cc:20: virtual void CleanUp();
OVERRIDE?

http://codereview.chromium.org/10872002/diff/10003/ui/viewer/viewer_process.c...
ui/viewer/viewer_process.cc:27: ViewerIOThread::~ViewerIOThread() {
can you add a blank line above?

http://codereview.chromium.org/10872002/diff/10003/ui/viewer/viewer_process.h
File ui/viewer/viewer_process.h (right):

http://codereview.chromium.org/10872002/diff/10003/ui/viewer/viewer_process.h...
ui/viewer/viewer_process.h:13: #include "ui/viewer/viewer_host_win.h"
can you forward declare this instead?

http://codereview.chromium.org/10872002/diff/10003/ui/viewer/viewer_process.h...
ui/viewer/viewer_process.h:30: // Returns the message loop that we perform I/O
coordination on (network
please, add blank line above.

[commit-bot: I haz the power, 2012-09-17 23:32:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/10872002/18001

[commit-bot: I haz the power, 2012-09-17 23:57:36]

Sorry for I got bad news for ya.
Compile failed with a clobber build.
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[tfarina, 2012-09-18 01:11:52]

did you fix the other nits I posted?

https://chromiumcodereview.appspot.com/10872002/diff/18001/ui/viewer/viewer_h...
File ui/viewer/viewer_host_win.h (right):

https://chromiumcodereview.appspot.com/10872002/diff/18001/ui/viewer/viewer_h...
ui/viewer/viewer_host_win.h:6: #define UI_VIEWER_VIEWER_VIEWER_HOST_WIN_H_
nit: UI_VIEWER_VIEWER_HOST_WIN_H_

there is an extra VIEWER here.

https://chromiumcodereview.appspot.com/10872002/diff/18001/ui/viewer/viewer_h...
ui/viewer/viewer_host_win.h:12: namespace aura { class RootWindow; }
ham? what is that :)

I think you meant:

namespace aura {
class FocusManager;
class RootWindow;

namespace shared {
class RootWindowCaptureClient;
}

}

Or did you do this way to save vertical lines?

https://chromiumcodereview.appspot.com/10872002/diff/18001/ui/viewer/viewer_h...
ui/viewer/viewer_host_win.h:15: class ViewerHostWin {
doesn't this needs to be in ui namespace? or even ui::viewer::, whatever...

[scottmg, 2012-09-18 03:09:36]

On 2012/09/18 01:11:52, tfarina wrote:
> did you fix the other nits I posted?

yes, those that were still applicable, except for the namespace.

> 
>
https://chromiumcodereview.appspot.com/10872002/diff/18001/ui/viewer/viewer_h...
> File ui/viewer/viewer_host_win.h (right):
> 
>
https://chromiumcodereview.appspot.com/10872002/diff/18001/ui/viewer/viewer_h...
> ui/viewer/viewer_host_win.h:6: #define UI_VIEWER_VIEWER_VIEWER_HOST_WIN_H_
> nit: UI_VIEWER_VIEWER_HOST_WIN_H_
> 
> there is an extra VIEWER here.

done.

> 
>
https://chromiumcodereview.appspot.com/10872002/diff/18001/ui/viewer/viewer_h...
> ui/viewer/viewer_host_win.h:12: namespace aura { class RootWindow; }
> ham? what is that :)
> 
> I think you meant:

ok.

> 
> namespace aura {
> class FocusManager;
> class RootWindow;
> 
> namespace shared {
> class RootWindowCaptureClient;
> }
> 
> }
> 
> Or did you do this way to save vertical lines?
> 
>
https://chromiumcodereview.appspot.com/10872002/diff/18001/ui/viewer/viewer_h...
> ui/viewer/viewer_host_win.h:15: class ViewerHostWin {
> doesn't this needs to be in ui namespace? or even ui::viewer::, whatever...

I don't know. This code is most closely associated with ui/surface, and that
doesn't have any namespaces. This will probably have to move to chrome
relatively soon anyway.