[Reland] [Extensions] Make extension message bubble factory platform-abstract

[Reland] [Extensions] Make extension message bubble factory platform-abstract

We want to show extension message bubbles on multiple platforms;
the first step towards this is to make the bubble factory
platform-abstract. Do so, and also add a handful of tests for the
process of showing the bubble.

BUG=474092
[email protected] (no relevant changes since original land)

Committed: https://crrev.com/70fc60535fb99318170676856ecf1044ba083f68
Cr-Commit-Position: refs/heads/master@{#325269}

[Devlin, 2015-04-14 16:31:03]

Patchset #2 (id:20001) has been deleted

[Devlin, 2015-04-14 16:37:37]

[email protected] changed reviewers:
+ [email protected]

[Devlin, 2015-04-14 16:37:38]

Finnur, mind taking a look?  This is a reland of
https://codereview.chromium.org/1078543002/.  Patch Set 1 has the original
patch, Patch Set 2 is the revised version.

https://codereview.chromium.org/1087713002/diff/40001/chrome/browser/ui/toolb...
File chrome/browser/ui/toolbar/toolbar_actions_bar.cc (right):

https://codereview.chromium.org/1087713002/diff/40001/chrome/browser/ui/toolb...
chrome/browser/ui/toolbar/toolbar_actions_bar.cc:643: // CreateActions() can be
called as part of the browser window set up, which
This is what was actually causing the crash (funny thing - it would only show up
on official builders, running windows, and then only from a non-initial browser
window opening, after the initial window opens and doesn't need to show a
bubble, and after an unpacked extension without a browser action has been added
- gotta love edge cases! ;)).  But it was also indicative of the fact that we
didn't really have any tests for the bubble itself.  I added a handful, enabled
on all views platforms, one of which handles the specific case mentioned above
(which did crash before this fix).

[Finnur, 2015-04-15 14:51:37]

LGTM, could of nits.

https://codereview.chromium.org/1087713002/diff/40001/chrome/browser/ui/toolb...
File chrome/browser/ui/toolbar/toolbar_actions_bar.cc (right):

https://codereview.chromium.org/1087713002/diff/40001/chrome/browser/ui/toolb...
chrome/browser/ui/toolbar/toolbar_actions_bar.cc:643: // CreateActions() can be
called as part of the browser window set up, which
Woot.

https://codereview.chromium.org/1087713002/diff/60001/chrome/browser/ui/views...
File
chrome/browser/ui/views/extensions/extension_message_bubble_view_browsertest.cc
(right):

https://codereview.chromium.org/1087713002/diff/60001/chrome/browser/ui/views...
chrome/browser/ui/views/extensions/extension_message_bubble_view_browsertest.cc:128:
// Tests that the extension bubble will show on startup.
nit: Would be good for the test that exercises the crash to link to the bug.
(I'm assuming this is the one, but you know where to place it).

https://codereview.chromium.org/1087713002/diff/60001/chrome/browser/ui/views...
chrome/browser/ui/views/extensions/extension_message_bubble_view_browsertest.cc:133:
IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleViewBrowserTest,
nit: missing line break above this.

[Finnur, 2015-04-15 14:52:07]

And thank you for also providing the original patch. Phew! :)

[Devlin, 2015-04-15 16:56:49]

https://codereview.chromium.org/1087713002/diff/60001/chrome/browser/ui/views...
File
chrome/browser/ui/views/extensions/extension_message_bubble_view_browsertest.cc
(right):

https://codereview.chromium.org/1087713002/diff/60001/chrome/browser/ui/views...
chrome/browser/ui/views/extensions/extension_message_bubble_view_browsertest.cc:128:
// Tests that the extension bubble will show on startup.
On 2015/04/15 14:51:37, Finnur wrote:
> nit: Would be good for the test that exercises the crash to link to the bug.
> (I'm assuming this is the one, but you know where to place it).

Done.

https://codereview.chromium.org/1087713002/diff/60001/chrome/browser/ui/views...
chrome/browser/ui/views/extensions/extension_message_bubble_view_browsertest.cc:133:
IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleViewBrowserTest,
On 2015/04/15 14:51:37, Finnur wrote:
> nit: missing line break above this.

It was a conscious decision, since the one above is a PRE, but I guess that's
kind of arbitrary styling. ;)  Fixed.

[Devlin, 2015-04-15 16:57:36]

[email protected] changed reviewers:
+ [email protected]

[Devlin, 2015-04-15 16:57:46]

The CQ bit was checked by [email protected]

[Devlin, 2015-04-15 16:57:46]

The patchset sent to the CQ was uploaded after l-g-t-m from [email protected]
Link to the patchset: https://codereview.chromium.org/1087713002/#ps80001
(title: "Finnur's")

[commit-bot: I haz the power, 2015-04-15 16:57:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1087713002/80001

[commit-bot: I haz the power, 2015-04-15 17:49:26]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2015-04-15 17:50:16]

Patchset 4 (id:??) landed as
https://crrev.com/70fc60535fb99318170676856ecf1044ba083f68
Cr-Commit-Position: refs/heads/master@{#325269}