Rename NetLog test classes to match the renamed TestNetLog class.

Rename NetLog test classes to match the renamed TestNetLog class.

CapturedNetLogEntry -> TestNetLogEntry
CapturingNetLogObserver -> TestNetLogObserver
net_log_unittest.h -> test_net_log_util.h

[email protected]
BUG=481277
Committed: https://crrev.com/43758e61f3d72653caa2e534bb990b4e14abdcdc
Cr-Commit-Position: refs/heads/master@{#328183}

[mmenke, 2015-04-27 11:58:11]

[email protected] changed reviewers:
+ [email protected]

[mmenke, 2015-04-27 11:58:12]

https://codereview.chromium.org/1092403005/diff/60001/net/log/test_net_log_ut...
File net/log/test_net_log_util.h (left):

https://codereview.chromium.org/1092403005/diff/60001/net/log/test_net_log_ut...
net/log/test_net_log_util.h:21: }
This wasn't being used anywhere.

https://codereview.chromium.org/1092403005/diff/60001/net/net.gyp
File net/net.gyp (right):

https://codereview.chromium.org/1092403005/diff/60001/net/net.gyp#newcode547
net/net.gyp:547: 'log/test_net_log_util.h',
Note that I moved this from net_unittests to net_test_util.

[eroman, 2015-04-27 21:37:32]

lgtm with the following comments...

https://codereview.chromium.org/1092403005/diff/60001/net/log/net_log_util_un...
File net/log/net_log_util_unittest.cc (right):

https://codereview.chromium.org/1092403005/diff/60001/net/log/net_log_util_un...
net/log/net_log_util_unittest.cc:74: TestNetLogObserver capturing_observer;
should we rename the variable too?

https://codereview.chromium.org/1092403005/diff/60001/net/log/net_log_util_un...
net/log/net_log_util_unittest.cc:105: TestNetLogObserver capturing_observer;
should we rename the variable?

https://codereview.chromium.org/1092403005/diff/60001/net/log/test_net_log_ob...
File net/log/test_net_log_observer.h (right):

https://codereview.chromium.org/1092403005/diff/60001/net/log/test_net_log_ob...
net/log/test_net_log_observer.h:24: // TestNetLogObserver is an implementation
of NetLog::ThreadSafeObserver
Rather than exposing TestNetLogObserver, can we just make it local to
test_net_log.cc ?

test_net_log.cc is a small and fairly silly file otherwise. And I don't think
there is value in exposing TestNetLogObserver for re-use elsewhere, since we
generally want to reduce/eliminate observers. Using a TestNetLog should be
enough.

I think the only place that TestNetLogObserver is being used right now is in a
test, to call a method in net_log_util. However that just needs a general
ThreadSafeObserver so we could expose something like an "observer()" accessor in
TestNetLog or something.

https://codereview.chromium.org/1092403005/diff/60001/net/net.gyp
File net/net.gyp (right):

https://codereview.chromium.org/1092403005/diff/60001/net/net.gyp#newcode547
net/net.gyp:547: 'log/test_net_log_util.h',
On 2015/04/27 11:58:12, mmenke (Out 4-27 to 5-1) wrote:
> Note that I moved this from net_unittests to net_test_util. 

sgtm

[mmenke, 2015-05-04 19:50:02]

[email protected] changed reviewers:
+ [email protected]

[mmenke, 2015-05-04 19:50:03]

[+bengr]:  TBRing you for the DRP unittest change.  This just renames a net
class it uses.

https://codereview.chromium.org/1092403005/diff/60001/net/log/net_log_util_un...
File net/log/net_log_util_unittest.cc (right):

https://codereview.chromium.org/1092403005/diff/60001/net/log/net_log_util_un...
net/log/net_log_util_unittest.cc:74: TestNetLogObserver capturing_observer;
On 2015/04/27 21:37:31, eroman wrote:
> should we rename the variable too?

Done.

https://codereview.chromium.org/1092403005/diff/60001/net/log/net_log_util_un...
net/log/net_log_util_unittest.cc:105: TestNetLogObserver capturing_observer;
On 2015/04/27 21:37:32, eroman wrote:
> should we rename the variable?

Done.

https://codereview.chromium.org/1092403005/diff/60001/net/log/test_net_log_ob...
File net/log/test_net_log_observer.h (right):

https://codereview.chromium.org/1092403005/diff/60001/net/log/test_net_log_ob...
net/log/test_net_log_observer.h:24: // TestNetLogObserver is an implementation
of NetLog::ThreadSafeObserver
On 2015/04/27 21:37:32, eroman wrote:
> Rather than exposing TestNetLogObserver, can we just make it local to
> test_net_log.cc ?
> 
> test_net_log.cc is a small and fairly silly file otherwise. And I don't think
> there is value in exposing TestNetLogObserver for re-use elsewhere, since we
> generally want to reduce/eliminate observers. Using a TestNetLog should be
> enough.
> 
> I think the only place that TestNetLogObserver is being used right now is in a
> test, to call a method in net_log_util. However that just needs a general
> ThreadSafeObserver so we could expose something like an "observer()" accessor
in
> TestNetLog or something.

I'm fine with that, but think it goes beyond the scope of this CL.  I'll send
out a followup.

[mmenke, 2015-05-04 20:00:06]

The CQ bit was checked by [email protected]

[mmenke, 2015-05-04 20:00:07]

The patchset sent to the CQ was uploaded after l-g-t-m from [email protected]
Link to the patchset: https://codereview.chromium.org/1092403005/#ps80001
(title: "Response to comments")

[commit-bot: I haz the power, 2015-05-04 20:01:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1092403005/80001

[commit-bot: I haz the power, 2015-05-04 21:09:59]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-05-04 21:10:56]

Patchset 5 (id:??) landed as
https://crrev.com/43758e61f3d72653caa2e534bb990b4e14abdcdc
Cr-Commit-Position: refs/heads/master@{#328183}