Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 1105393003: Used base::StringPairs where appropriate in base/ (Closed)

Created:
5 years, 7 months ago by packland
Modified:
5 years, 7 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use base::StringPairs where appropriate in base/ BUG=412250 Committed: https://crrev.com/b7936175f7aea96cf620328c13901c70d0d86437 Cr-Commit-Position: refs/heads/master@{#327456}

Patch Set 1 #

Patch Set 2 : StringPairs in base #

Patch Set 3 : Updated line that referred to old definition of StringPair #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -7 lines) Patch
M base/process/internal_linux.cc View 1 2 1 chunk +2 lines, -4 lines 0 comments Download
M base/vlog.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 20 (7 generated)
packland
Please have a look. Should I include more than one of these changes in each ...
5 years, 7 months ago (2015-04-28 19:38:35 UTC) #2
Lei Zhang
On 2015/04/28 19:38:35, packland wrote: > Please have a look. Should I include more than ...
5 years, 7 months ago (2015-04-28 20:32:00 UTC) #3
packland
These were all the occurrences I could find in base. Please have another look. Thank ...
5 years, 7 months ago (2015-04-28 20:53:03 UTC) #4
Lei Zhang
lgtm
5 years, 7 months ago (2015-04-28 21:33:15 UTC) #6
Lei Zhang
In your commit message, you have a typo and "base/process" should just be "base/". Can ...
5 years, 7 months ago (2015-04-28 21:34:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1105393003/20001
5 years, 7 months ago (2015-04-28 21:36:42 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/66494) linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 7 months ago (2015-04-28 21:47:26 UTC) #12
Lei Zhang
On 2015/04/28 21:34:15, Lei Zhang wrote: > In your commit message, you have a typo ...
5 years, 7 months ago (2015-04-28 21:53:34 UTC) #13
packland
I updated the commit message now. Sorry for the inconvenience. However, I do not understand ...
5 years, 7 months ago (2015-04-28 22:00:50 UTC) #14
Lei Zhang
On 2015/04/28 22:00:50, packland wrote: > I updated the commit message now. Sorry for the ...
5 years, 7 months ago (2015-04-28 22:24:26 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1105393003/40001
5 years, 7 months ago (2015-04-29 07:03:44 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-04-29 09:24:51 UTC) #19
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 09:25:39 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b7936175f7aea96cf620328c13901c70d0d86437
Cr-Commit-Position: refs/heads/master@{#327456}

Powered by Google App Engine
This is Rietveld 408576698